New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AliasFactory.createAliasForProperty() doesn't use "parent" argument #944

Closed
cowwoc opened this Issue Sep 19, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@cowwoc
Contributor

cowwoc commented Sep 19, 2014

The method in question takes a parent argument but never uses it. Is this a bug? Should the argument be removed?

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Sep 19, 2014

Member

AliasFactory is more internal API and should be put in default visibility in Querydsl 4.0.0. Until then it is probably safer to keep the signature backwards compatible. The implementation might have changed.

Member

timowest commented Sep 19, 2014

AliasFactory is more internal API and should be put in default visibility in Querydsl 4.0.0. Until then it is probably safer to keep the signature backwards compatible. The implementation might have changed.

@timowest timowest added the postponed label Sep 20, 2014

@timowest timowest added this to the 4.0.0 milestone Nov 17, 2014

@timowest timowest removed the postponed label Jan 15, 2015

@timowest timowest added the progress label Jan 28, 2015

@Shredder121 Shredder121 closed this in #1144 Jan 31, 2015

@timowest timowest removed the progress label Jan 31, 2015

@timowest timowest removed the progress label Mar 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment