Javadoc build errors under JDK 8 #945

Closed
cowwoc opened this Issue Sep 19, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@cowwoc
Contributor

cowwoc commented Sep 19, 2014

The Javadoc gods are angry at you :)

Aside from the 10,000 warnings about undocumented code, JDK 8 aborts the build process due to some malformed HTML tags, references to non-existent types and parameter names.

I will open a PR shortly, but you should really try to fix those warnings over time :) It's not the first time I run across a method whose usage is unclear because the parameters are undocumented. (I would do it for you but I can't document methods I don't understand)

@cowwoc

This comment has been minimized.

Show comment
Hide comment
@cowwoc

cowwoc Sep 19, 2014

Contributor

I've fixed all Javadoc errors up to the point where the CUBRID maven repository causes the build to abort. I'll resume the work once the repository is fixed.

Contributor

cowwoc commented Sep 19, 2014

I've fixed all Javadoc errors up to the point where the CUBRID maven repository causes the build to abort. I'll resume the work once the repository is fixed.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Sep 19, 2014

Member

Thanks for starting the effort. The CUBRID issue has been fixed now.

Member

timowest commented Sep 19, 2014

Thanks for starting the effort. The CUBRID issue has been fixed now.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Sep 21, 2014

Member

Javadoc validation in JDK 8 can be skipped in the build using -Dmaven.javadoc.skip=true

Member

timowest commented Sep 21, 2014

Javadoc validation in JDK 8 can be skipped in the build using -Dmaven.javadoc.skip=true

cowwoc pushed a commit to cowwoc/querydsl that referenced this issue Sep 22, 2014

cowwoc pushed a commit to cowwoc/querydsl that referenced this issue Sep 23, 2014

@cowwoc

This comment has been minimized.

Show comment
Hide comment
@cowwoc

cowwoc Sep 23, 2014

Contributor

I'm stuck again :) See: #959

Contributor

cowwoc commented Sep 23, 2014

I'm stuck again :) See: #959

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Sep 25, 2014

Member

I'm closing this, since the javadoc errors are fixed. Documenting the public interface of Querydsl better can be handled via new issues.

@cowwoc Do you still get the compilation error?

Member

timowest commented Sep 25, 2014

I'm closing this, since the javadoc errors are fixed. Documenting the public interface of Querydsl better can be handled via new issues.

@cowwoc Do you still get the compilation error?

@timowest timowest closed this Sep 25, 2014

@timowest timowest added this to the 3.5.0 milestone Sep 25, 2014

@cowwoc

This comment has been minimized.

Show comment
Hide comment
@cowwoc

cowwoc Sep 26, 2014

Contributor

@timowest The master branch now builds for me. Thank you!

Contributor

cowwoc commented Sep 26, 2014

@timowest The master branch now builds for me. Thank you!

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Sep 30, 2014

Member

Released in 3.5.0

Member

timowest commented Sep 30, 2014

Released in 3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment