Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc build errors under JDK 8 #945

Closed
cowwoc opened this issue Sep 19, 2014 · 7 comments
Closed

Javadoc build errors under JDK 8 #945

cowwoc opened this issue Sep 19, 2014 · 7 comments
Milestone

Comments

@cowwoc
Copy link
Contributor

@cowwoc cowwoc commented Sep 19, 2014

The Javadoc gods are angry at you :)

Aside from the 10,000 warnings about undocumented code, JDK 8 aborts the build process due to some malformed HTML tags, references to non-existent types and parameter names.

I will open a PR shortly, but you should really try to fix those warnings over time :) It's not the first time I run across a method whose usage is unclear because the parameters are undocumented. (I would do it for you but I can't document methods I don't understand)

@cowwoc
Copy link
Contributor Author

@cowwoc cowwoc commented Sep 19, 2014

I've fixed all Javadoc errors up to the point where the CUBRID maven repository causes the build to abort. I'll resume the work once the repository is fixed.

@timowest
Copy link
Member

@timowest timowest commented Sep 19, 2014

Thanks for starting the effort. The CUBRID issue has been fixed now.

@timowest
Copy link
Member

@timowest timowest commented Sep 21, 2014

Javadoc validation in JDK 8 can be skipped in the build using -Dmaven.javadoc.skip=true

@cowwoc
Copy link
Contributor Author

@cowwoc cowwoc commented Sep 23, 2014

I'm stuck again :) See: #959

@timowest
Copy link
Member

@timowest timowest commented Sep 25, 2014

I'm closing this, since the javadoc errors are fixed. Documenting the public interface of Querydsl better can be handled via new issues.

@cowwoc Do you still get the compilation error?

@timowest timowest closed this Sep 25, 2014
@timowest timowest added this to the 3.5.0 milestone Sep 25, 2014
@cowwoc
Copy link
Contributor Author

@cowwoc cowwoc commented Sep 26, 2014

@timowest The master branch now builds for me. Thank you!

@timowest
Copy link
Member

@timowest timowest commented Sep 30, 2014

Released in 3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.