From c62fb7002fdfac03566dbbb90cf5ee3b549a6784 Mon Sep 17 00:00:00 2001 From: Maciej Bodek Date: Fri, 11 Aug 2023 17:22:44 +0200 Subject: [PATCH] Deprecate `durable` upload setting --- .../src/scenes/Import/ImportCSVFiles/index.tsx | 1 - .../ImportCSVFiles/upload-settings-dialog.tsx | 15 --------------- packages/web-console/src/utils/questdb.ts | 1 - 3 files changed, 17 deletions(-) diff --git a/packages/web-console/src/scenes/Import/ImportCSVFiles/index.tsx b/packages/web-console/src/scenes/Import/ImportCSVFiles/index.tsx index 3daff884d..e44fe2507 100644 --- a/packages/web-console/src/scenes/Import/ImportCSVFiles/index.tsx +++ b/packages/web-console/src/scenes/Import/ImportCSVFiles/index.tsx @@ -129,7 +129,6 @@ export const ImportCSVFiles = ({ onImported }: Props) => { skipLev: false, delimiter: "", atomicity: "skipCol", - durable: false, maxUncommitedRows: MAX_UNCOMMITTED_ROWS, }, isUploading: false, diff --git a/packages/web-console/src/scenes/Import/ImportCSVFiles/upload-settings-dialog.tsx b/packages/web-console/src/scenes/Import/ImportCSVFiles/upload-settings-dialog.tsx index d08893f88..49f73003c 100644 --- a/packages/web-console/src/scenes/Import/ImportCSVFiles/upload-settings-dialog.tsx +++ b/packages/web-console/src/scenes/Import/ImportCSVFiles/upload-settings-dialog.tsx @@ -84,7 +84,6 @@ export const UploadSettingsDialog = ({ forceHeader, skipLev, atomicity, - durable, maxUncommitedRows, } = file.settings @@ -94,7 +93,6 @@ export const UploadSettingsDialog = ({ forceHeader, skipLev, atomicity, - durable, maxUncommitedRows, } @@ -190,19 +188,6 @@ export const UploadSettingsDialog = ({ ), defaultValue: settings.skipLev, }, - { - type: "switch", - name: "durable", - label: "Durable", - description: ( - <> - When set to true, import will be resilient against OS - errors or power losses by forcing the data to be fully persisted - before sending a response back to the user. - - ), - defaultValue: settings.durable, - }, ] return ( diff --git a/packages/web-console/src/utils/questdb.ts b/packages/web-console/src/utils/questdb.ts index 0a3689436..cfe2cb852 100644 --- a/packages/web-console/src/utils/questdb.ts +++ b/packages/web-console/src/utils/questdb.ts @@ -145,7 +145,6 @@ export type UploadModeSettings = { skipLev: boolean delimiter: string atomicity: string - durable: boolean maxUncommitedRows: number }