From 8445a8e4450878cbe727e67b7ac9f637f87487d3 Mon Sep 17 00:00:00 2001
From: Will Martin <contact@willmartian.com>
Date: Thu, 12 Oct 2023 10:34:53 -0400
Subject: [PATCH] [CL-104] fix overlay + virtual scroll view recycling bug
 (#6179)

* close menu overlay when no longer visible

* prevent infinite loop in fallback-src directive

* block scrolling when menu is open

* disable view recycling; use reposition strategy
---
 .../components/vault-items/vault-items.component.html     | 2 +-
 libs/angular/src/directives/fallback-src.directive.ts     | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/apps/web/src/app/vault/components/vault-items/vault-items.component.html b/apps/web/src/app/vault/components/vault-items/vault-items.component.html
index ba8acf6ddfd5..05ac26964f3a 100644
--- a/apps/web/src/app/vault/components/vault-items/vault-items.component.html
+++ b/apps/web/src/app/vault/components/vault-items/vault-items.component.html
@@ -58,7 +58,7 @@
       </tr>
     </ng-container>
     <ng-template body let-rows$>
-      <ng-container *cdkVirtualFor="let item of rows$">
+      <ng-container *cdkVirtualFor="let item of rows$; templateCacheSize: 0">
         <tr
           *ngIf="item.collection"
           bitRow
diff --git a/libs/angular/src/directives/fallback-src.directive.ts b/libs/angular/src/directives/fallback-src.directive.ts
index 11bce2052b7d..082c8534fa31 100644
--- a/libs/angular/src/directives/fallback-src.directive.ts
+++ b/libs/angular/src/directives/fallback-src.directive.ts
@@ -6,9 +6,15 @@ import { Directive, ElementRef, HostListener, Input } from "@angular/core";
 export class FallbackSrcDirective {
   @Input("appFallbackSrc") appFallbackSrc: string;
 
+  /** Only try setting the fallback once. This prevents an infinite loop if the fallback itself is missing. */
+  private tryFallback = true;
+
   constructor(private el: ElementRef) {}
 
   @HostListener("error") onError() {
-    this.el.nativeElement.src = this.appFallbackSrc;
+    if (this.tryFallback) {
+      this.el.nativeElement.src = this.appFallbackSrc;
+      this.tryFallback = false;
+    }
   }
 }