BUG FIX - get_model_configs() fix for InternVL and Llava #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-hemagnih
approved these changes
Mar 12, 2025
Contributor
|
Please fix DCO |
Contributor
|
@quic-dhirajku can you resolve the DCO issue |
…c based on num_patches. Signed-off-by: quic-dhirajku <quic_dhirajku@quicinc.com>
quic-dhirajku
force-pushed
the
vlm_patches
branch
from
f69b847 to
d09eaa5
Compare
quic-rishinr
approved these changes
Mar 18, 2025
quic-swatia
pushed a commit
that referenced
this pull request
Mar 20, 2025
made few changes in the modeling files of both models for this method to now work appropriately. Signed-off-by: quic-dhirajku <quic_dhirajku@quicinc.com>
quic-rishinr
pushed a commit
to quic-rishinr/efficient-transformers
that referenced
this pull request
Mar 21, 2025
made few changes in the modeling files of both models for this method to now work appropriately. Signed-off-by: quic-dhirajku <quic_dhirajku@quicinc.com> Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
qcdipankar
pushed a commit
to qcdipankar/efficient-transformers
that referenced
this pull request
Apr 1, 2025
made few changes in the modeling files of both models for this method to now work appropriately. Signed-off-by: quic-dhirajku <quic_dhirajku@quicinc.com> Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
eplatero97
pushed a commit
to eplatero97/efficient-transformers
that referenced
this pull request
Apr 29, 2025
made few changes in the modeling files of both models for this method to now work appropriately. Signed-off-by: quic-dhirajku <quic_dhirajku@quicinc.com>
eplatero97
pushed a commit
to eplatero97/efficient-transformers
that referenced
this pull request
Apr 29, 2025
made few changes in the modeling files of both models for this method to now work appropriately. Signed-off-by: quic-dhirajku <quic_dhirajku@quicinc.com> Signed-off-by: eplatero <quic_eplatero@quicinc.com>
eplatero97
pushed a commit
to eplatero97/efficient-transformers
that referenced
this pull request
Apr 29, 2025
made few changes in the modeling files of both models for this method to now work appropriately. Signed-off-by: quic-dhirajku <quic_dhirajku@quicinc.com> Signed-off-by: eplatero <quic_eplatero@quicinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made few changes in the modeling files of both models for this method to now work appropriately.