10$: Warn on let ({x} = y);

Before refactor:

let x;
({x} = y);

After refactor:

let ({x} = y);  // Bug! This uses an undeclared variable 'x' and calls a function named 'let'.

Conditions for this diagnostic:

Function call with a variable let as the callee.
Exactly one function argument.
Function argument is an assignment expression with =.
Function argument's left-hand side is an object literal.

@strager

@strager Shouldn't this be considered an error? Code like this crashes in Node.js on line 5:

const y = {x: 45, z: "helloworld"};
let z;
({z} = y);
console.log(z);
let ({x} = y);
console.log(x);

@msharipov This doesn't crash:

const y = {x: 45, z: "helloworld"};
let z;
({z} = y);
console.log(z);

function let(arg) {
  console.log("let", arg);
}
let x;
let ({x} = y);
console.log(x);

@strager

@strager Ah, I see. Could you please assign this to me?

I claim this for-hire task. I expect payment after I complete this task. I will email the quick-lint-js team if I am assigned this task.

@Nyx1on

@Nyx1on Someone else already claimed this task. If @msharipov is unresponsive, I'll give the task you @Nyx1on.

I'm still working on this, it's just taking a while.

feat(fe): add warning for 'let({x} = y);'

Navigation Menu

Repository navigation

10$: Warn on let ({x} = y); #1203

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

10$: Warn on let ({x} = y); #1203

Description

Activity

persimmonious commented on Feb 23, 2024

strager commented on Feb 24, 2024

persimmonious commented on Feb 24, 2024

Nyx1on commented on Mar 2, 2024

strager commented on Mar 2, 2024

persimmonious commented on Mar 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions