VS Code: After installation, diag showed on first token

[strager]

https://clips.twitch.tv/SparklingDignifiedCougarResidentSleeper-RHRLrGb3lgZtUhVu

[strager]

I couldn't reproduce the issue on VS Code 1.66.0 or 1.67.2 on Linux x86_64.

[SidneyNemzer]

I think this is a minimal repro (different error):

qljs-repro.mp4

1. Create a file with the content const a = a;
2. Verify that QLJS errors on the last a
3. Reload the window
4. Actual: QLJS errors on const until an update is triggered
   Expected: the error is still on the last a

I used F1 > Start Extension Bisect to verify that other extensions didn't influence the bug. Not sure if there's an easy way to disable all extensions except one.

Version: 1.67.2 (system setup)
Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5
Date: 2022-05-17T18:15:52.058Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Windows_NT x64 10.0.19043

[strager]

I can repro on Windows with VS Code 1.67.2 (x64) using @SidneyNemzer's method.

[strager]

I tracked it down to a call to napi_create_double creating a strange napi_value. More investigation needed.

[strager]

The xmm1 register (double parameter of napi_create_double) gets corrupted by a function called by __delayLoadHelper2. The trampoline generated by GNU binutils' dlltool does not preserve xmm1, despite xmm1 being a volatile register according to the Windows x64 ABI.

I think the fix is to save xmm1 and other volatile SSE and AVX registers before calling __delayLoadHelper2. I have tried to build binutils, but it looks like the latest version generates archives which crash at run-time. I don't know the exact reasons for the crash yet.

[strager]

Patching dlltool fixed the issue. I emailed my tentative patch to upstream.

We still need to apply a workaround in quick-lint-js, since we won't get a newer dlltool for a while.

[strager]

Fixed in commit 40d1291.