Corrections to SingleThreadedEventHandlingStrategy, SocketAcceptor/Initiator #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chrjohn
commented
Jun 19, 2018
chrjohn
commented
- Reverted changes from SingleThreadedEventHandlingStrategy thread should be interrupted on stop() #192 since we actually want to process all messages on stop().
…/Initiator. - Reverted changes from #192 since we actually want to process all messages on stop().
It does not make sense to call getMessage() in that case.
to ensure that the session timer is not stopped by Message Processor thread when using stopHandlingMessages(true)
…HandlingStrategy.stopHandlingMessages(true). Otherwise it could happen on quick restarts that the Message Processor thread stopped the SessionTimer concurrently which lead to an unresponsive FIX session, i.e. no Logon sent, no Heartbeats.
Member
Author
|
I've re-ran the build about 10 times and there were no more errors. Hopefully the unstable unit tests should be a thing of the past now. |
Member
Author
|
Bummer, the last build had a problem. |
Member
Author
|
However, I am going to merge this since the remaining failure seems purely to be related to the acceptance test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.