Skip to content

Conversation

@esanchezros
Copy link
Contributor

@esanchezros esanchezros commented Feb 10, 2021

Fixes #365

@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Feb 11, 2021
@chrjohn chrjohn self-requested a review February 11, 2021 11:46
Copy link
Member

@chrjohn chrjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion you can remove the @Deprecated methods. Since adding a new parameter to the methods is a breaking change anyway (and only the new methods are called in the code), we can simply change the method signature without deprecating the old methods. What do you think?
Edit: so if we left the @Deprecated methods in the code then everyone who implemented these would be curious why the listener methods are not called anymore.

@esanchezros
Copy link
Contributor Author

My intention was to allow users to notice the @Deprecated methods and let them change their implementations at their discretion, before removing them. But on the other, you're right, their listeners won't get called at all. I will update the PR accordingly.

@chrjohn
Copy link
Member

chrjohn commented Feb 15, 2021

Note to self: once #368 is merged, there will be another method signature to change.

@chrjohn chrjohn added the TODO label Mar 31, 2021
@chrjohn chrjohn changed the title Add SessionID to SessionStateListener methods Add SessionID to SessionStateListener methods May 4, 2021
@chrjohn chrjohn removed the TODO label Sep 27, 2021
@chrjohn
Copy link
Member

chrjohn commented Sep 27, 2021

Note to self: once #368 is merged, there will be another method signature to change.

Implemented onConnectException().

@chrjohn chrjohn merged commit ce6c3ed into quickfix-j:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SessionID to SessionStateListener methods

2 participants