-
Notifications
You must be signed in to change notification settings - Fork 657
Add SessionID to SessionStateListener methods
#370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SessionID to SessionStateListener methods
#370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion you can remove the @Deprecated methods. Since adding a new parameter to the methods is a breaking change anyway (and only the new methods are called in the code), we can simply change the method signature without deprecating the old methods. What do you think?
Edit: so if we left the @Deprecated methods in the code then everyone who implemented these would be curious why the listener methods are not called anymore.
|
My intention was to allow users to notice the |
|
Note to self: once #368 is merged, there will be another method signature to change. |
SessionID to SessionStateListener methods
Implemented |
Fixes #365