update Mockito to 3.x and switch build to JDK17 #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjohn
changed the title
chrjohn
force-pushed
the
chrjohn-mockito
branch
from
dfa76d4 to
5cbc44a
Compare
chrjohn
changed the title
gtoison
pushed a commit
to gtoison/quickfixj
that referenced
this pull request
Jan 9, 2025
* update mockito to check for better JDK17 support * Replaced `stub()` by `when()`. * Changed Mockito matchers since they no longer match `null`. * added --add-opens to prevent test failure * Added profile for surefire on JDK8 and other JDKs
gtoison
pushed a commit
to gtoison/quickfixj
that referenced
this pull request
Jan 9, 2025
* update mockito to check for better JDK17 support * Replaced `stub()` by `when()`. * Changed Mockito matchers since they no longer match `null`. * added --add-opens to prevent test failure * Added profile for surefire on JDK8 and other JDKs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to get buildable project for JDK17.
Switch build from JDK15 to JDK17 LTS.