New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUNDLE-SYSTEMS fails when systems depend on "asdf" #116

Closed
quicklisp opened this Issue Apr 29, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@quicklisp
Owner

quicklisp commented Apr 29, 2015

This is a two-part problem.

The indexes should not have "asdf" as a required system anywhere.

BUNDLE-SYSTEMS should warn (or signal a continuable error) when a required system isn't found.

@dimitri

This comment has been minimized.

Show comment
Hide comment
@dimitri

dimitri Jan 20, 2016

Can it be as simple as in the following quick-editing?

(defun add-systems-recursively (names bundle)
  (with-consistent-dists
    (labels ((add-one (name)
               (let ((system
                      (restart-case
                          (ensure-system name bundle)
                        (ignore ()
                          :report "Ignore this system in the bundle."))))
                 (when system
                   (dolist (required-system-name (required-systems system))
                     (add-one required-system-name))))))
      (map nil #'add-one names)))
  bundle)

dimitri commented Jan 20, 2016

Can it be as simple as in the following quick-editing?

(defun add-systems-recursively (names bundle)
  (with-consistent-dists
    (labels ((add-one (name)
               (let ((system
                      (restart-case
                          (ensure-system name bundle)
                        (ignore ()
                          :report "Ignore this system in the bundle."))))
                 (when system
                   (dolist (required-system-name (required-systems system))
                     (add-one required-system-name))))))
      (map nil #'add-one names)))
  bundle)

@quicklisp quicklisp closed this in 2ef7c73 Jan 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment