Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retina graphics? #1044

Closed
lexrus opened this issue Aug 13, 2012 · 20 comments
Closed

Retina graphics? #1044

lexrus opened this issue Aug 13, 2012 · 20 comments

Comments

@lexrus
Copy link

@lexrus lexrus commented Aug 13, 2012

I can't ignore the roughness on my Retina Macbook Pro.

@masonk
Copy link

@masonk masonk commented Aug 13, 2012

Can you be more specific? I haven't noticed anything the matter on mine. What exactly is the problem? Which skin are you using? If you haven't already, check out http://www.catb.org/esr/faqs/smart-questions.html.

@lexrus
Copy link
Author

@lexrus lexrus commented Aug 13, 2012

It's very clear that the developer should add @2x-sized artworks for Retina display.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 14, 2012

It's certainly something we need to do, yes.

As for when, unfortunately we cannot say. Most of us are coders and not graphic designers so we'll need to consider our options.

http://developer.apple.com/library/mac/documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/HighResolutionOSX.pdf

@fblaser
Copy link

@fblaser fblaser commented Oct 26, 2012

I could volunteer to do this.

I quickly looked in the repository and only found the low-res versions of the images. Anyone in the know could point me to the origin of (some of) the images ?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 26, 2012

Thank you very much for volunteering, but please do not worry about this.
We are working on it ;-)

On 26 October 2012 17:49, fblaser notifications@github.com wrote:

I could volunteer to do this.

I quickly looked in the repository and only found the low-res versions of
the images. Anyone in the know could point me to the origin of (some of)
the images ?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1044#issuecomment-9819354.

@fblaser
Copy link

@fblaser fblaser commented Oct 26, 2012

Sounds good ! Thanks for doing it !

Let me know if I can help in any way.

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 26, 2012

I don't suppose you want to tackle the images in the iTunes plug-in? :-)

What you see in the repo/plug-in is what we have, so it might involve creating things from scratch in many cases.

@fblaser
Copy link

@fblaser fblaser commented Oct 27, 2012

@skurfer Why not !

Quick question : I didn't see where the equalizer icon is used. Is it needed ?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 27, 2012

Quick question : I didn't see where the equalizer icon is used. Is it needed ?

It's used in Preferences > Catalog > Plugins > iTunes > iTunes Equalizer Presets, if I remember correctly.
Not sure if it's used anywhere else, Rob will know.
If it isn't, then I think the icon could be re-designed, since it doesn't scale down to a 16x16px icon that well.

Btw - awesome!
@skurfer quite rightly pointed out that we are sorted for the core app (and the internal plugins) but feel free to get your hands dirty with any other plugins :)

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 27, 2012

Yes, it's used for the related catalog and trigger presets, and if you enable it in the catalog, it gets assigned to each EQ setting you have in iTunes. That one probably needs redoing more than any of them, as all I did was grab an image of the window. It's terrible. :-) Thanks for helping out!

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 27, 2013

Graphics should be retina now in ß71

We're still working on the last few, but the majority are done.

@thepaul
Copy link

@thepaul thepaul commented Jan 27, 2013

I'm probably missing something, but I have ß71 and pretty much all the icons still look very rough. Here's a screenshot of the menu bar icon:

Screen Shot 2013-01-27 at 9 16 57 AM

Is this ticket intended to be for something else?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 27, 2013

Hmm... seems like you're right. Whilst we have the icons sitting here, they weren't included in the release package. We'll make sure they're there for the next release.

Reopening

@pjrobertson pjrobertson reopened this Jan 27, 2013
@skurfer
Copy link
Member

@skurfer skurfer commented Jan 27, 2013

Yeah, I had to add them to a branch and add them to the Xcode project the other day. (Nice problem to have.)

Quicksilver Menu Icon at 2X

I thought we were waiting on Dan to finish the rest before putting them in.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 27, 2013

Yeah, maybe we were - keeping them for 1.0 is probably better anyway.
...although I did tweet about new retina icons. Seems like nobody notices :/

P.S. stop showing off Rob ;-)

On 27 January 2013 17:30, Rob McBroom notifications@github.com wrote:

Yeah, I had to add them to a branch and add them to the Xcode project the
other day. (Nice problem to have.)

[image: Quicksilver Menu Icon at 2X]https://dl.dropbox.com/u/2214419/GitHub/qs2X.png

I thought we were waiting on Dan to finish the rest before putting them in.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1044#issuecomment-12757730.

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 28, 2013

Another thing we need to fix in this area is the way icons are created for various sizes. Here's a side-by-side of the same album cover in Finder vs. Quicksilver.

Retina Album Side-by-side

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 28, 2013

Another thing we need to fix in this area is the way icons are created
for various sizes. Here's a side-by-side of the same album cover in Finder
vs. Quicksilver.

Is this a QSResourceManager thing?

On 28 January 2013 02:01, Rob McBroom notifications@github.com wrote:

Another thing we need to fix in this area is the way icons are created for
various sizes. Here's a side-by-side of the same album cover in Finder vs.
Quicksilver.

[image: Retina Album Side-by-side]https://dl.dropbox.com/u/2214419/GitHub/retina%20album.png


Reply to this email directly or view it on GitHubhttps://github.com//issues/1044#issuecomment-12766117.

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 28, 2013

I think we need to change the NSImage category, but it’s probably not confined to that.

Update This probably has the answer: https://developer.apple.com/library/mac/#documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/Introduction/Introduction.html#//apple_ref/doc/uid/TP40012302-CH1-SW1

@skurfer
Copy link
Member

@skurfer skurfer commented Feb 21, 2013

Have you had a chance to look at the icons in the iTunes plug-in @fblaser?

@asmeurer
Copy link

@asmeurer asmeurer commented Sep 15, 2013

The gear open icon could be sharper.

screenshot 2013-09-14 19 13 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants