⇧⌘letter with no selection makes a mess #1122

Closed
skurfer opened this Issue Sep 18, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@skurfer
Member

skurfer commented Sep 18, 2012

With nothing selected, hit ⇧⌘X (or some other letter). The dSelector will remain empty, and the default object (not action) match for X will appear in the aSelector. From there, I can’t find any way to get things working again (where actions appear in the second pane). A restart is required.

Not too long ago, @pjrobertson prevented tabbing to the second pane when there was no selection to prevent something similar. This is probably he same issue, just triggered by a different way to manipulate the aSelector.

@pjrobertson

This comment has been minimized.

Show comment Hide comment
@pjrobertson

pjrobertson Sep 19, 2012

Member

Man you're good! It'll need a check for

if(![dSelector objectValue]) {
return;
}

wherever the ⌘⇧letter is checked. Or something along those lines.

Member

pjrobertson commented Sep 19, 2012

Man you're good! It'll need a check for

if(![dSelector objectValue]) {
return;
}

wherever the ⌘⇧letter is checked. Or something along those lines.

@ghost ghost assigned pjrobertson Oct 8, 2012

skurfer added a commit that referenced this issue Oct 9, 2012

Merge pull request #1160 from pjrobertson/i1122
Don't perform key equivalents if the dSelector is empty. Fixes #1122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment