Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ß71: use "/" to open recent documents, the most recent one is not listed as the first #1244

Closed
ybian opened this issue Nov 27, 2012 · 6 comments · Fixed by #1249
Closed
Assignees

Comments

@ybian
Copy link
Contributor

ybian commented Nov 27, 2012

I like to use "/" to open my recent documents, for example, I do the following every day:

Choose "Xcode" -> Hit "/" -> Select a project -> Enter to open it.

The problem is, before ß71, the most recent project was always the first one in the list after "/", but now, it is not, actually it is often listed as the last one.

Could this be a regression?

@skurfer
Copy link
Member

skurfer commented Nov 27, 2012

Hmmm. They are in a different order, but I'm not sure why. We added iCloud documents to that list, but I don't think we changed anything for recent documents. I'm not convinced that they're in the "wrong" order now, though. I'll have to see what's going on.

@ghost ghost assigned skurfer Nov 27, 2012
@HenningJ
Copy link
Contributor

I think something about the string rank was change in ß71. Like
children are ranked according to rank, instead of...whatever it was
before. I guess that makes sense for most things, but not for recent
documents. There you want the most recent one on top.

On Tue, Nov 27, 2012 at 3:43 PM, Rob McBroom notifications@github.com wrote:

Hmmm. They are in a different order, but I'm not sure why. We added iCloud
documents to that list, but I don't think we changed anything for recent
documents. I'm not convinced that they're in the "wrong" order now, though.
I'll have to see what's going on.


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member

skurfer commented Nov 27, 2012

I think something about the string rank was change in ß71.

Yeah, that's what I was thinking – I'm the one that changed it – but I haven't looked at the code yet to see if the recents are even ranked.

@skurfer
Copy link
Member

skurfer commented Nov 27, 2012

They're not ranked. I used an NSMutableSet when adding iCloud documents to the list (so an iCloud document that was also opened recently wouldn't appear twice). Sets don't preserve order. :-( Should be easy enough to fix.

@ybian
Copy link
Contributor Author

ybian commented Nov 29, 2012

@skurfer Thanks for fixing it so soon.

@skurfer
Copy link
Member

skurfer commented Nov 29, 2012

No problem. I couldn't remember having to "search" recent documents so often in the past, but couldn't put my finger on it until you brought up a specific point where it changed. Then, knowing that it could be fixed, it really started to annoy me. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants