Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textmate String Ranker doesn't work #14

Closed
tonyc opened this issue Dec 3, 2009 · 16 comments
Closed

Textmate String Ranker doesn't work #14

tonyc opened this issue Dec 3, 2009 · 16 comments
Assignees
Labels

Comments

@tonyc
Copy link

@tonyc tonyc commented Dec 3, 2009

When installing and enabling the TextMate String Ranker, no results appear when you search for a term. I prefer the TM ranker's method of matching, and I'd love to see it working again.

I'm not sure if this is the right place to open this -- is the ranker maintained with QS or elsewhere (e.g. macromates.com).

@tiennou
Copy link
Member

@tiennou tiennou commented Dec 4, 2009

The TextMate Ranker plugin source is available, but I don't use TextMate. I will see if that's easily fixable just from source.

@tonyc
Copy link
Author

@tonyc tonyc commented Dec 4, 2009

Thanks. If there's anything I can do to help, just let me know.

@mauritium
Copy link

@mauritium mauritium commented Apr 17, 2011

In fact, the ranker has nothing to do with TextMate, the name is misleading. From the QS manual:

You can also choose a slightly different matching algorithm by installing the TextMate Ranker (+)
plug-in (which requires advanced features to be enabled) and selecting it as the String Ranker
handler in Preferences.

It makes two changes to the algorithm. The first is that it favors more beginning of word letters
that are touched. E.g., if you type AM it will match Activity Monitor over Adium since two begin-
ning of word letters are matched instead of just one. The second difference is that it favors input
that matches a higher percentage of the words. So the input AM will favor Activity Monitor over
Audio MIDI Setup since 2/2 (100%) of words are matched instead of 2/3 (67%).

As a result, if you’re the type to favor typing acronyms over continuous letters in the name of
something, you’ll probably prefer the TextMate Ranker. However there are reported problems
with matching things in the third pane such as when you use the Open With… action or the
Email to… action. You may find that no results match in the third pane.

Has anybody had a look at this? I find the built-in ranker more or less unusable, would be great to have the TextMate ranker back.

@ghost ghost assigned fheckl Apr 27, 2011
fheckl added a commit to fheckl/Quicksilver that referenced this issue Apr 27, 2011
HenningJ added a commit that referenced this issue May 2, 2011
@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented May 2, 2011

This will be fixed in ß60. At that time a new plugin will be released.

@HenningJ HenningJ closed this as completed May 2, 2011
@tonyc
Copy link
Author

@tonyc tonyc commented Jun 5, 2011

Is B60 still pointing at the old plugins somehow? In the UI, the TM ranker
(and many of the plugins) are still listed as updated on 09/01/06.

On Mon, May 2, 2011 at 2:30 PM, HenningJ <
reply@reply.github.com>wrote:

This will be fixed in 60. At that time a new plugin will be released.

Reply to this email directly or view it on GitHub:
#14 (comment)

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 5, 2011

This will be fixed in ß60.

Make that ß61. :)

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 5, 2011

@tonyc: Yes, the pluginlist is still pointing to an old list. That will be fixed in ß61 as skurfer mentioned.
But the TextMate Stringranker Plugin is fixed in ß60. It's just that somebody still has to release the updated plugin. @skurfer or @pjrobertson could grad the lastest source from https://github.com/quicksilver/Plugins/tree/master/QSDuffsRanker/trunk/QSDuffsRanker , build it and put it on the homepage?

@tonyc, once that is done, you'll be able to download the new plugin from http://qsapp.com/plugins/

@tonyc
Copy link
Author

@tonyc tonyc commented Jun 5, 2011

Thanks, guys!

T

On Sun, Jun 5, 2011 at 1:19 PM, HenningJ <
reply@reply.github.com>wrote:

@tonyc: Yes, the pluginlist is still pointing to an old list. That will be
fixed in 61 as skurfer mentioned.
But the TextMate Stringranker Plugin is fixed in 60. It's just that
somebody still has to release the updated plugin. @skurfer or @pjrobertson
could grad the lastest source from
https://github.com/quicksilver/Plugins/tree/master/QSDuffsRanker/trunk/QSDuffsRanker, build it and put it on the homepage?

@tonyc, once that is done, you'll be able to download the new plugin from
http://qsapp.com/plugins/

Reply to this email directly or view it on GitHub:
#14 (comment)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 5, 2011

@fheckl can the commit HenningJ linked to above be turned into a pull request?

One small thing: the implementation file has the extension .mm (DuffStringRanker.mm)

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 6, 2011

@pjrobertson: everything is already merged (I think :-)).
And the extension is correct. It's a C++ file, that's why it needs the .mm extension

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 6, 2011

Sorry - right you are :)

I think I know why I was reluctant to release this on QSApp.com - since QSApp.com doesn't have any version checking, users with ß59 may download it and have problems. It's the same case for the WebSearch Module and my 1Password Plugin.

I guess it's just a simple case of adding a (ß60+ ONLY) to the name - should be pretty easy

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 6, 2011

right, I didn't think about that. Until we get the plugin stuff, adding a warning to the name is probably the easiest solution. :-)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 6, 2011

OK done.

Can somebody who uses/knows about the plugin download it from
http://qsapp.com/plugins and let me know if it's right? I just built it and
hoped for the best :)

On 6 June 2011 18:24, HenningJ <
reply@reply.github.com>wrote:

right, I didn't think about that. Until we get the plugin stuff, adding a
warning to the name is probably the easiest solution. :-)

Reply to this email directly or view it on GitHub:
#14 (comment)

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 6, 2011

Seems to work. @tonyc please report back as well once you tried it.

@tonyc
Copy link
Author

@tonyc tonyc commented Jun 6, 2011

Works great, thanks! The updated name didn't appear correctly in the UI but it seems to function properly.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 6, 2011

Its actual name doesn't include the (60 ONLY) part, if that's what you're
referring to.

Great that it's working - I'll tweet about it now from LoveQuicksilver
twitter

On 7 June 2011 07:18, tonyc <
reply@reply.github.com>wrote:

Works great, thanks! The updated name didn't appear correctly in the UI but
it seems to function properly.

Reply to this email directly or view it on GitHub:
#14 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants