Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Trigger #1424

Closed
sarinkuruvilla opened this issue Mar 14, 2013 · 9 comments
Closed

Custom Trigger #1424

sarinkuruvilla opened this issue Mar 14, 2013 · 9 comments
Assignees

Comments

@sarinkuruvilla
Copy link

@sarinkuruvilla sarinkuruvilla commented Mar 14, 2013

This is a bug, Adding more than one Custom trigger changes the first one with a copy of the second one. So basically you can only have one Custom Trigger as of now.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Mar 14, 2013

Can you please elaborate on what you are doing/seeing. I am not quite sure what you mean from your issue

@sarinkuruvilla
Copy link
Author

@sarinkuruvilla sarinkuruvilla commented Mar 14, 2013

When I try to create first Custom Trigger it works fine , but when I add a second custom trigger and if i copy and paste the command "open /Applications/test.app" it saves that as a custom trigger but it also replaces first custom trigger with the same command as second custom trigger.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 14, 2013

Are you literally pasting the text of a Unix command, or are you copying something from a trigger that opens an application? When you say "the same command", do you mean a Unix command in the first pane, or the action (such as "Open") in the second pane?

@sarinkuruvilla
Copy link
Author

@sarinkuruvilla sarinkuruvilla commented Mar 15, 2013

So yea im pasting the text, i type " . " which lets me type the command, and then i paste the command "open /user/name/folder/folder/folder/folder/file.app" and when i say same command I mean the Unix command in the first pane not the action.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 15, 2013

Son of a— You're exactly right. The text from the first trigger gets replaced. We'll look into it.

In the meantime, there's a much more straightforward way to open applications: Select the application in the first pane and the Open action in the second (which is most likely the default).

@sarinkuruvilla
Copy link
Author

@sarinkuruvilla sarinkuruvilla commented Mar 15, 2013

http://youtu.be/pNyOPhxDQCU here is quick video too. yea open application was just my dummy code to show you the bug

@sarinkuruvilla
Copy link
Author

@sarinkuruvilla sarinkuruvilla commented Mar 15, 2013

I use it to open screensaver app to lock my computer when walking away... is there a better way to do that? coz I cant pull up that app directly in quicksilver

@ghost ghost assigned skurfer Mar 15, 2013
@WBCad
Copy link

@WBCad WBCad commented Mar 22, 2013

I've got something weird happening with custom triggers as well.
I hit add and first time it let's me enter the command but then creates a blank entry.
Then when I hit "+" to have another go it creates two blank entries for which I can only edit the hotkeys and doesn't prompt for a command. I do already have one trigger in place that doesn't seem to be effected so maybe it's part of the same problem.

@skurfer skurfer mentioned this issue Apr 18, 2013
@skurfer
Copy link
Member

@skurfer skurfer commented Apr 22, 2013

I've looked into this a bit, but still no fix. Here's what I've found (so I don't forget):

  1. This only affects triggers where the direct object is a string.
  2. This only happens if you create two (or more) such triggers in the same "session". That is, relaunching QS and creating a new trigger does not corrupt existing triggers.
  3. The direct object in the old trigger is changed twice. It's set to nil when you create a new trigger, then set to the same string as the new trigger when you save it.
  4. You can see the value change in - [QSTriggersPrefPane editTriggerCommand:callback:] when setCommand: is called.

KVO weirdness?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants