Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QS Guide Internal Command #1448

Closed
hmelman opened this issue Mar 30, 2013 · 6 comments
Closed

QS Guide Internal Command #1448

hmelman opened this issue Mar 30, 2013 · 6 comments

Comments

@hmelman
Copy link

@hmelman hmelman commented Mar 30, 2013

There are Internal Commands for QS Preferences, Triggers, Catalog and Plugins. There should be another for QS Guide.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Mar 31, 2013

Internal commands that do what? Open up those preference panes?

On 31 March 2013 06:00, hmelman notifications@github.com wrote:

There are Internal Commands for QS Preferences, Triggers, Catalog and
Plugins. There should be another for QS Guide.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1448
.

@hmelman
Copy link
Author

@hmelman hmelman commented Mar 31, 2013

Yes, that's what they do, with the Run action. Since there are the four, seems like there should be a fifth, for consistency sake (hobgoblins and all that).

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Mar 31, 2013

OK, I've just looked but here's what I find:

  • There's no 'QS Plugins' internal command
  • the 'QS Preferences' command just opens the preferences window and not the actual preferences pane

Can you confirm, and I'll fix those as well

@hmelman
Copy link
Author

@hmelman hmelman commented Mar 31, 2013

Yes you're right, I'm seeing the same thing.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Mar 31, 2013

OK, I've fixed those and also changed the names a little (incase you're updating the manual)

They're now "show XXX preferences" where XXX is plugins/catalog/triggers etc.

The update one is now called 'Check for Quicksilver Update'

If you view the files changed in the pull request you'll be able to tell which names have changed

@hmelman
Copy link
Author

@hmelman hmelman commented Mar 31, 2013

Thanks. Done. You changed "QS Command Window" to "Show Command Window", there's also a "QS Command Window with Text" that should probably be changed to match.

skurfer added a commit that referenced this issue Jun 17, 2013
Add more internal commands for opening prefs. Fixes #1448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants