Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text with URL inside should be classified as an URL #1509

Closed
studgeek opened this issue Jun 2, 2013 · 2 comments
Closed

Text with URL inside should be classified as an URL #1509

studgeek opened this issue Jun 2, 2013 · 2 comments

Comments

@studgeek
Copy link

studgeek commented Jun 2, 2013

For example, "this is some text http://qsapp.com/" should not be treated as an URL.

Discussion is here - https://groups.google.com/forum/?hl=en&fromgroups#!topic/blacktree-quicksilver/r3w1rOAn-Lo

Unit test that detects it is here - https://github.com/skurfer/Quicksilver/commit/84f435626daf6e1582c74791f567f3850680beb4
@pjrobertson
Copy link
Member

I fixed this yesterday with #1508 :)

@studgeek
Copy link
Author

studgeek commented Jun 3, 2013

Nice, thanks!

skurfer added a commit that referenced this issue Jun 13, 2013
@skurfer
Merge pull request #1508 from pjrobertson/misc
272e6e9 
Misc - mainly fixing unit tests. Fixes #1509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjrobertson @studgeek