Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Detection #1512

Closed
adam52 opened this issue Jun 5, 2013 · 5 comments
Closed

URL Detection #1512

adam52 opened this issue Jun 5, 2013 · 5 comments

Comments

@adam52
Copy link

@adam52 adam52 commented Jun 5, 2013

I noticed that QuickSilver does not detect URLs created by DEVONthink Pro. These are of the form:

x-devonthink-item://

Best,
-Adam

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 5, 2013

Can you give an example of a full URL?

Quicksilver is most likely looking for a TLD (.com, .uk, .org etc) at the end of the URL and as such is failing.

Although I can confirm that with the changes in #1508 a URL like x-devonthink-item://something works great :)

On 5 Meh 2013, at 09:21, adam52 notifications@github.com wrote:

I noticed that QuickSilver does not detect URLs created by DEVONthink Pro. These are of the form:

x-devonthink-item://

Best,
-Adam


Reply to this email directly or view it on GitHub.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 5, 2013

Fixed by #1508

@adam52
Copy link
Author

@adam52 adam52 commented Jun 5, 2013

Thanks Patrick! Here is an example of a complete URL from DEVONthink:

x-devonthink-item://309E79B2-C837-4044-9AA1-D2858F64EF6A

On Jun 4, 2013, at 7:36 PM, Patrick Robertson notifications@github.com wrote:

Can you give an example of a full URL?

Quicksilver is most likely looking for a TLD (.com, .uk, .org etc) at the end of the URL and as such is failing.

Although I can confirm that with the changes in #1508 a URL like x-devonthink-item://something works great :)

On 5 Meh 2013, at 09:21, adam52 notifications@github.com wrote:

I noticed that QuickSilver does not detect URLs created by DEVONthink Pro. These are of the form:

x-devonthink-item://

Best,
-Adam


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

@adam52
Copy link
Author

@adam52 adam52 commented Jun 5, 2013

I just downloaded the latest version but QS still doesn't recognize this type of link.

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 5, 2013

@pjrobertson has submitted a change that fixes this, but the change still needs to be tested and approved. Once it's approved, it'll be in the following release.

@skurfer skurfer closed this as completed Oct 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants