Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger scope should test on bundle ID and path #1531

Closed
timvisher opened this issue Jul 8, 2013 · 1 comment
Closed

Trigger scope should test on bundle ID and path #1531

timvisher opened this issue Jul 8, 2013 · 1 comment

Comments

@timvisher
Copy link

@timvisher timvisher commented Jul 8, 2013

Entering Google Chrome on a system which has both Google Chrome 25 and Google Chrome installed incorrectly adds Google Chrome 25 to the scope list.

This seems to be because both identify themselves as the same bundle id.

pjrobertson added a commit that referenced this issue Dec 5, 2013
…scope view

Fixes #1531
Plus: Add a menu to the token to show the represented object
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 5, 2013

OK so the issue title is a little misleading. Quicksilver doesn't care about path, it only stores the bundle ID. It's the OS that gives the name Google Chrome 25 when we ask it "what is the name of the app with bundle ID xxxx.

I think it's more useful for QS to be ambiguous about apps (disable/enable triggers for any app with the bundle id com.google.chrome) so I plan on leaving it like that.
I do see what you mean about the Google Chrome 25 bit being misleading (the trigger will actually be scoped to any Google Chrome app, it's just the name that's confusing)

I've changed this to display the display name of the bundle (from the Info.plist). To make it easier to understand, I've also added a menu to the tokens (click the down arrow) which will show the bundle ID associated with the name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants