Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data destructive bug with "Make Alias In..." action! #1547

Closed
Sesquipedalian opened this issue Jul 31, 2013 · 6 comments
Closed

Data destructive bug with "Make Alias In..." action! #1547

Sesquipedalian opened this issue Jul 31, 2013 · 6 comments

Comments

@Sesquipedalian
Copy link

@Sesquipedalian Sesquipedalian commented Jul 31, 2013

Problem description

In version 1.0.1, if the "Make Alias In..." action is used to create an alias file in the same directory as the original file that the alias is supposed to point to, the original file is overwritten with the alias file.

I recommend that a fix for this bug should be pushed out right away, since it can instantly, silently, and unexpectedly destroy user data.

Example

[First pane:] ~/Desktop/testfile.txt
[Second pane:] Make Alias In...
[Third pane:] ~/Desktop

Result: An alias file is created at ~/Desktop named testfile.txt that points to nothing but itself. The original file is gone, along with any data it contained.

Expected behaviour

What should occur is for a new alias file named "[name of original file] alias" to be created, as the Finder does.

Workaround

For now, I am disabling this action and replacing it with an AppleScript telling the Finder to make the new alias file.

Further information

  • This does not occur if the original item is a folder or package, but it does occur with flat files (binaries, text files, etc.). For folders and packages, the action simply does nothing.
  • The "Make Link In..." and "Make Hard Link In..." actions also both fail silently when trying to make a link in the same directory as the original file, but neither one overwrites the existing data (well, a hard link couldn't really do that anyway).
@skurfer
Copy link
Member

@skurfer skurfer commented Aug 1, 2013

Submitted a potential fix. Now let's hope someone has time to test and merge it. 😃

I just saw @pjrobertson a minute ago.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 1, 2013

Closed 💃

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 1, 2013

that was meant to be a :D ...

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 1, 2013

Rob will get a release out tomorrow morning. Thanks for the heads up Sesquipedalian and detailed description.

@Sesquipedalian
Copy link
Author

@Sesquipedalian Sesquipedalian commented Aug 1, 2013

No problem, Patrick. Glad it could be resolved quickly. Thanks to both you and Rob.

Jon Stovell

On 2013-07-31, at 11:57 PM, Patrick Robertson notifications@github.com wrote:

Rob will get a release out tomorrow morning. Thanks for the heads up Sesquipedalian and detailed description.


Reply to this email directly or view it on GitHub.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 1, 2013

Whoops, I always forget it's you Jon ;-)

No need for thanks my way. I just clicked the big green button. Rob did all the work :D

On 1 Awst 2013, at 12:09, Sesquipedalian notifications@github.com wrote:

No problem, Patrick. Glad it could be resolved quickly. Thanks to both you and Rob.

Jon Stovell

On 2013-07-31, at 11:57 PM, Patrick Robertson notifications@github.com wrote:

Rob will get a release out tomorrow morning. Thanks for the heads up Sesquipedalian and detailed description.


Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants