Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Exclusion of filetype for folder #16

Closed
qiushihe opened this issue Dec 3, 2009 · 10 comments
Closed

Feature Request: Exclusion of filetype for folder #16

qiushihe opened this issue Dec 3, 2009 · 10 comments

Comments

@qiushihe
Copy link

qiushihe commented Dec 3, 2009

QS currently have the ability for me to specify which filetype (extension) to include for indexing for a particular folder in the catalog -- and if it's left empty, then all filetypes in the folder will be indexed -- but most of the time what I need is to specify which filetype to be excluded.

For example, I would like to index my "projects" folders but would like to exclude all ".svn" folders and ".git" folders as well. I may also want to index a windows partition but have all ".exe", ".dll", etc. excluded as well.

Currently I have to manually exclude all the folders I don't want by unchecking them in the content panel. It's would be so much easier if I can say: for this folder, index all its content except files that matches this regex.

@qiushihe
Copy link
Author

qiushihe commented Aug 1, 2010

in case anyone actually cares, I've done this myself: http://surrealtime.tumblr.com/qs

@quicksilver
Copy link
Collaborator

qiushihe; just so I can maybe close this, have you made a pull request to us to merge the changes you made to the main branch?

I can't remember if it's already been done or not!

I'll test out your release if not, then pull it over :)

P.S. you may need to re-fork from this new repository and re-add the changes since your changes were made quite a few months back

@qiushihe
Copy link
Author

qiushihe commented Mar 8, 2011

Hi, I don't remember if I made the pull request. But I'll send one over tonight :)

@qiushihe
Copy link
Author

qiushihe commented Mar 9, 2011

okay, pull request sent.

@qiushihe
Copy link
Author

And I did re-forked and apparently my commits are already merged in. I did a build and verified the the feature is working as expected. So I think you can close this issue now :)

@quicksilver
Copy link
Collaborator

Hmm.... still doesn't work for me.

Step:

Open the catalog prefs:
Click the '+' add file & folder scanner
Pick a directory with .txt and other files in.
Set 'include contents' to 'folder contents'
Exclude box pops up.
Type in '.txt' or txt (Tried both)
click the refresh icon arrow
The .txt files still show up in the 'contents' pane.

@qiushihe
Copy link
Author

hmm, interesting... it's definitely not doing that for me. I followed the exact steps you listed and the text files disappeared after clicking the refresh icon

@quicksilver
Copy link
Collaborator

Are you running the version downloadable from this repo, or your own?

@qiushihe
Copy link
Author

I'm not sure what you mean by "downloadable from this repo", but I basically forked this repo (I just did like 30min ago), checked out my fork, and built the app.

@quicksilver
Copy link
Collaborator

Sorry, downloadable from the downloads page:

https://github.com/quicksilver/Quicksilver/downloads

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant