Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open Preferences under 10.7 (Lion) #1628

Closed
skurfer opened this issue Sep 30, 2013 · 5 comments · Fixed by #1630
Closed

Can't open Preferences under 10.7 (Lion) #1628

skurfer opened this issue Sep 30, 2013 · 5 comments · Fixed by #1630
Labels

Comments

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 30, 2013

This is not an issue with 1.1.0, but is happening with the current master, which contains a number of changes.

The first time you open preferences, you don't see anything. The second time you try, a blank window appears with the spinner in the upper-left spinning forever.

I took some samples after opening the prefs with both a build from master and 1.1.0.

Failed: http://cl.ly/text/2Q021d1k0B2U
Working: http://cl.ly/text/0z1T381F1b3U

I've checked that none of the NIBs were changed to 10.8. I haven't done a bisect because I really don't want to install the dev tools in the 10.7 VM, but I can if it comes to it.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 1, 2013

Hmm… they look almost identical to me. Seems strange. Do you get the spinner no matter which prefs you open (Catalog, Plugins etc.)?

On 1 Oct 2013, at 03:05, Rob McBroom notifications@github.com wrote:

This is not an issue with 1.1.0, but is happening with the current master, which contains a number of changes.

The first time you open preferences, you don't see anything. The second time you try, a blank window appears with the spinner in the upper-left spinning forever.

I took some samples after opening the prefs with both a build from master and 1.1.0.

Failed: http://cl.ly/text/2Q021d1k0B2U
Working: http://cl.ly/text/0z1T381F1b3U

I've checked that none of the NIBs were changed to 10.8. I haven't done a bisect because I really don't want to install the dev tools in the 10.7 VM, but I can if it comes to it.


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 1, 2013

Yeah. Same behavior. Nothing the first time (after a relaunch), and just the spinner after the second try. The only thing that changes is if you go to the main Preferences, then click one of the other panes, then come back. At that point, the items on the left show up, but still nothing on the right.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 3, 2013

OK, I broke down and installed Xcode in the VM. The problem is 80cbf0b, which uses instantiateWithOwner:topLevelObjects:, introduced in 10.8.

So… drop 10.7 support? 😉

skurfer added a commit that referenced this issue Oct 3, 2013
This reverts part of 80cbf0b to preserve compatibly with 10.7.

fixes #1628
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 4, 2013

Sorry I didn't reply to the last email. I was going to suggest just symlinking the app to your VM then building/doing the git bisect on your host OS. I guess you're all set up now anyways so… :)
Do you have the 10.7 SDK on your ML install? If so we should maybe add a step before releasing:

  • Change the SDK in Project > Quicksilver > Build Settings to "OS X 10.7" and test the build
  • Change back to 10.8
  • …release etc.

So… drop 10.7 support?

When you first mentioned the problem I kind of thought… yeah we should. It's pretty impractical for us to keep support for 10.7, since we can't test on it (well, we can now). Maybe once 10.9 is out for a few months we can ditch it.

On 3 Oct 2013, at 23:41, Rob McBroom notifications@github.com wrote:

OK, I broke down and installed Xcode in the VM. The problem is 80cbf0b, which uses instantiateWithOwner:topLevelObjects:, introduced in 10.8.

So… drop 10.7 support?


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 4, 2013

I was going to suggest just symlinking the app to your VM then building/doing the git bisect on your host OS.

In a shared folder or something? Might work.

Do you have the 10.7 SDK on your ML install?

No. I checked that first, but couldn't see a way to install it.

It's pretty impractical for us to keep support for 10.7, since we can't test on it (well, we can now). Maybe once 10.9 is out for a few months we can ditch it.

I was mostly kidding, but yeah, once 10.9 ships, it's fair game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants