Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 crashes during setup #1731

Closed
skurfer opened this issue Dec 20, 2013 · 3 comments
Closed

1.2.0 crashes during setup #1731

skurfer opened this issue Dec 20, 2013 · 3 comments
Labels
Milestone

Comments

@skurfer
Copy link
Member

@skurfer skurfer commented Dec 20, 2013

To start fresh, run defaults delete com.blacktree.Quicksilver. (Deleting the prefs file won’t do the trick under 10.9.)

First crash is on line 43 of QSWindow.m. It seems self has been freed. If you fix that by adding @synchronized (self) {} or by just storing the result of [self windowNumber] earlier in the method, you can get to the next crash…

Next is line 45 of QSCGSTranstion.m. It happens as soon as you hit “Continue” on the welcome screen. It’s another EXC_BAD_ACCESS but I can’t figure out what this one’s complaining about. All the variables appear to still be valid.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 16, 2014

Should we scrap CGSTransition completely? I think so.

My guess is the crash is coming because something in the private framework has changed, or if it's ARC related we're not saying a return value is retained/released or whatever

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 16, 2014

Interesting, using CGSPrivate from http://www.fvalente.org/blog/wp-content/uploads/2012/03/CGSPrivate.h doesn't cause the crash, but the transitions are dodgy

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 16, 2014

Although I propose just removing these lines from QSSetupAssistant.m:

  • 174, 175, 179

Seeing the setup assistant without the transitions is actually much cleaner and way more 2000s... :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants