Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 crash accessing trigger prefs #1843

Closed
hmelman opened this issue May 17, 2014 · 7 comments · Fixed by #1854
Closed

1.2.0 crash accessing trigger prefs #1843

hmelman opened this issue May 17, 2014 · 7 comments · Fixed by #1854
Milestone

Comments

@hmelman
Copy link

@hmelman hmelman commented May 17, 2014

I was away until today, my iMac was off. I booted and QS auto-started and updated to 1.2.0

I found that my mouse trigger (hide app when moused moved to corner) didn't work. command-space worked to bring up the command window and then command-comma worked to bring up prefs. I then clicked on the Triggers button (I never remember command-singlequote) and QS crashed. This was repeatable. I could not get to the triggers prefs through any means.

Other HotKey triggers seemed to work. ⌃⌘G brought up a google search, etc. I could not mouse to the side of the screen to bring up the shelf.

I restored the QS.app from Time Machine and everything is working fine. I'm guessing the mouse triggers plugin needs to be updated. I did send in a crash report from the first crash. Let me know if there's more I can supply.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 17, 2014

Hehe, thanks ;-)

Could you post some of the crash logs here, or if you've been uploading them to the server - let me know the name of your Mac (so I can find the crash logs relating to you)

@skurfer
Copy link
Member

@skurfer skurfer commented May 17, 2014

After reading the e-mail I was (maybe) able to reproduce it.

Thread 15 Crashed:: Dispatch queue: com.apple.root.high-priority
0   libobjc.A.dylib                 0x00007fff900800e6 objc_release + 22
1   com.blacktree.QSCore            0x00000001057295ab -[QSObject setCache:] + 64
2   com.blacktree.QSCore            0x0000000105729548 -[QSObject cache] + 85
3   com.blacktree.QSCore            0x00000001057292f4 -[QSObject setObject:forCache:] + 70
4   com.blacktree.QSCore            0x000000010572fc7d -[QSObject(FileHandling) infoRecord] + 801
5   com.blacktree.QSCore            0x000000010572fff3 -[QSObject(FileHandling) fileUTI] + 20
6   com.blacktree.QSCore            0x000000010572cf88 -[QSFileSystemObjectHandler loadIconForObject:] + 415
7   libdispatch.dylib               0x00007fff94c4c1bb _dispatch_call_block_and_release + 12
8   libdispatch.dylib               0x00007fff94c4928d _dispatch_client_callout + 8
9   libdispatch.dylib               0x00007fff94c4b082 _dispatch_root_queue_drain + 326
10  libdispatch.dylib               0x00007fff94c4c177 _dispatch_worker_thread2 + 40
11  libsystem_pthread.dylib         0x00007fff8c26eef8 _pthread_wqthread + 314
12  libsystem_pthread.dylib         0x00007fff8c271fb9 start_wqthread + 13

So I re-tried the stuff I did before with QSThreadSafeMutableDictionary. It still crashed the first time I tried, but I can’t get it to crash now no matter what. My guess is that self was getting released.

@skurfer
Copy link
Member

@skurfer skurfer commented May 17, 2014

And for the record, I created a Mouse trigger and it worked, but a mouse trigger for Current Application ⇥ Hide didn’t, so something’s broken somewhere.

CORRECTION: The trigger was set for “Click” instead of “Mouse Entered”, so it does actually work.

@hmelman
Copy link
Author

@hmelman hmelman commented May 17, 2014

On May 17, 2014, at 12:02 AM, Rob McBroom notifications@github.com wrote:

And for the record, I created a Mouse trigger and it worked, but a mouse trigger for Current Application ⇥ Hide didn’t, so something’s broken somewhere.

I find it an incredibly useful trigger. Maybe you guys would like to try it and get used to it and have it in your configurations ;)

Howard

@hmelman
Copy link
Author

@hmelman hmelman commented May 22, 2014

FYI, my mac is named Lumet.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 29, 2014

Thanks. The crash that @hmelman had is different from what @skurfer posted:

User Comments:

Right after upgrading to 1.2.0, found a trigger that didn't work, hit, command-space then command-comma then clicked on Triggers and it crashed.


------------------ CRASH REPORT -----------------


Process:         Quicksilver [2637]
Path:            /Applications/Quicksilver.app/Contents/MacOS/Quicksilver
Identifier:      com.blacktree.Quicksilver
Version:         1.2.0 (400B)
Code Type:       X86-64 (Native)
Parent Process:  ??? [1]
User ID:         505

Date/Time:       2014-05-16 21:50:57.637 -0400
OS Version:      Mac OS X 10.8.5 (12F45)
Report Version:  10

Crashed Thread:  23  Dispatch queue: com.apple.root.high-priority

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000

Application Specific Information:
*** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSDictionaryM: 0x7ffcc1f19880> was mutated while being enumerated.'
abort() called
terminate called throwing an exception

Application Specific Backtrace 1:
0   CoreFoundation                      0x00007fff938e8b06 __exceptionPreprocess + 198
1   libobjc.A.dylib                     0x00007fff911443f0 objc_exception_throw + 43
2   CoreFoundation                      0x00007fff9397ccb8 __NSFastEnumerationMutationHandler + 232
3   CoreFoundation                      0x00007fff938d486e __NSDictionaryEnumerate + 1022
4   QSCore                              0x000000010de3fea4 -[QSObject(PropertyList) initWithDictionary:] + 515
5   QSCore                              0x000000010de3f6c9 +[QSObject(PropertyList) objectWithDictionary:] + 119
6   QSCore                              0x000000010de249e0 -[QSCommand dObject] + 353
7   QSCore                              0x000000010de22c57 -[QSCommandObjectHandler loadIconForObject:] + 49
8   libdispatch.dylib                   0x00007fff89d7af01 _dispatch_call_block_and_release + 15
9   libdispatch.dylib                   0x00007fff89d770b6 _dispatch_client_callout + 8
10  libdispatch.dylib                   0x00007fff89d781fa _dispatch_worker_thread2 + 304
11  libsystem_c.dylib                   0x00007fff8dcb8cdb _pthread_wqthread + 404
12  libsystem_c.dylib                   0x00007fff8dca3191 start_wqthread + 13

I've fixed Howard's bug in #1854. Rob's bug... I'm not sure

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 29, 2014

...Now the other crash you had on 27th May seems to be related to your current application trigger that you mentioned (or at least, some trigger that contains a proxy)

This one I'm stumped on a bit more. Again, it's different from Rob's crash :/

User Comments:

My Safari (Toggle App) trigger didn't work, I activated QS, <E2><8C><98>' to bring up Triggers Prefs, then sorted by HotKey and scrolled briefly and QS crashed.


------------------ CRASH REPORT -----------------


Process:         Quicksilver [39153]
Path:            /Applications/Quicksilver.app/Contents/MacOS/Quicksilver
Identifier:      com.blacktree.Quicksilver
Version:         1.1.3 (4007)
Code Type:       X86-64 (Native)
Parent Process:  launchd [152]
User ID:         505

Date/Time:       2014-05-27 19:40:21.934 -0400
OS Version:      Mac OS X 10.8.5 (12F45)
Report Version:  10

Crashed Thread:  0  Dispatch queue: com.apple.main-thread

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x000007fcbe06efb4

VM Regions Near 0x7fcbe06efb4:
    CG backing stores      00000001cbc34000-00000001cbf32000 [ 3064K] rw-/rw- SM=SHM  
--> 
    JS JIT generated code  00002b1ea5400000-00002b1ea5401000 [    4K] ---/rwx SM=NUL  

Application Specific Information:
objc_msgSend() selector name: resolveProxyObject:


Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libobjc.A.dylib                     0x00007fff91139250 objc_msgSend + 16
1   com.blacktree.QSCore                0x000000010b09b98f -[QSProxyObject proxyObject] + 86
2   com.blacktree.QSCore                0x000000010b09bf80 -[QSProxyObject loadIcon] + 88
3   com.blacktree.QSCore                0x000000010b079e45 -[QSCommand icon] + 44
4   com.blacktree.QSCore                0x000000010b0a0f1f -[QSTrigger smallIcon] + 159
5   com.apple.Foundation                0x00007fff8fe45e89 -[NSObject(NSKeyValueCoding) valueForKey:] + 400
6   com.blacktree.QSInterface           0x000000010b10db91 -[QSImageAndTextCell setObjectValue:] + 187
7   com.apple.AppKit                    0x00007fff8a80f2ab -[_NSPlaceholderTextFieldPlugin showValue:inObject:] + 376
8   com.apple.AppKit                    0x00007fff8a80aaf4 -[NSValueBinder _adjustObject:mode:observedController:observedKeyPath:context:editableState:adjustState:] + 920
9   com.apple.AppKit                    0x00007fff8a838cf9 -[NSValueBinder updateOutlineColumnDataCell:forDisplayAtIndexPath:] + 152
10  com.apple.AppKit                    0x00007fff8a838c1a -[NSTextValueBinder updateOutlineColumnDataCell:forDisplayAtIndexPath:] + 85
11  com.apple.AppKit                    0x00007fff8a838a35 -[_NSBindingAdaptor outlineColumn:willDisplayCell:row:] + 351
12  com.apple.AppKit                    0x00007fff8a838082 -[NSTableView preparedCellAtColumn:row:] + 622
13  com.apple.AppKit                    0x00007fff8a837c1c -[NSOutlineView preparedCellAtColumn:row:] + 56
14  com.apple.AppKit                    0x00007fff8a654d00 -[NSTableView _dirtyVisibleCellsForKeyStateChange] + 628
15  com.apple.AppKit                    0x00007fff8a654169 -[NSTableView _windowChangedKeyState] + 280
16  com.apple.CoreFoundation            0x00007fff938e14a6 __NSArrayEnumerate + 582
17  com.apple.AppKit                    0x00007fff8a78290b -[NSView _windowChangedKeyState] + 154
18  com.apple.CoreFoundation            0x00007fff938e14a6 __NSArrayEnumerate + 582
19  com.apple.AppKit                    0x00007fff8a78290b -[NSView _windowChangedKeyState] + 154
20  com.apple.CoreFoundation            0x00007fff938e14a6 __NSArrayEnumerate + 582
21  com.apple.AppKit                    0x00007fff8a78290b -[NSView _windowChangedKeyState] + 154
22  com.apple.CoreFoundation            0x00007fff938e14a6 __NSArrayEnumerate + 582
23  com.apple.AppKit                    0x00007fff8a78290b -[NSView _windowChangedKeyState] + 154
24  com.apple.AppKit                    0x00007fff8a653dce -[NSSplitView _windowChangedKeyState] + 68
25  com.apple.CoreFoundation            0x00007fff938e14a6 __NSArrayEnumerate + 582
26  com.apple.AppKit                    0x00007fff8a78290b -[NSView _windowChangedKeyState] + 154
27  com.apple.CoreFoundation            0x00007fff938e14a6 __NSArrayEnumerate + 582
28  com.apple.AppKit                    0x00007fff8a78290b -[NSView _windowChangedKeyState] + 154
29  com.apple.CoreFoundation            0x00007fff938e14a6 __NSArrayEnumerate + 582
30  com.apple.AppKit                    0x00007fff8a78290b -[NSView _windowChangedKeyState] + 154
31  com.apple.AppKit                    0x00007fff8a7827f5 -[NSFrameView _windowChangedKeyState] + 93
32  com.apple.AppKit                    0x00007fff8a78228e -[NSWindow _setFrameNeedsDisplay:] + 169
33  com.apple.AppKit                    0x00007fff8a786670 -[NSWindow becomeMainWindow] + 41
34  com.apple.AppKit                    0x00007fff8ac9614e _NXShowKeyAndMain + 112
35  com.apple.AppKit                    0x00007fff8a7a77f7 -[NSApplication sendEvent:] + 2100
36  com.blacktree.Quicksilver           0x000000010af8ec9e 0x10af8c000 + 11422
37  com.apple.AppKit                    0x00007fff8a6be21a -[NSApplication run] + 636
38  com.apple.AppKit                    0x00007fff8a662bd6 NSApplicationMain + 869
39  com.blacktree.Quicksilver           0x000000010af8d9d4 0x10af8c000 + 6612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants