Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The first pane isn’t always cleared correctly #1846

Closed
skurfer opened this issue May 19, 2014 · 6 comments
Closed

The first pane isn’t always cleared correctly #1846

skurfer opened this issue May 19, 2014 · 6 comments
Labels
Milestone

Comments

@skurfer
Copy link
Member

@skurfer skurfer commented May 19, 2014

It looks like #203 and something similar to #670 are back.

Select multiple files with the comma trick. The selection isn’t cleared in either of these scenarios:

  1. Run the “Get File URL” action.
  2. Dismiss the interface and call it back with a trigger like “Search Artists”.
@skurfer skurfer added this to the 1.2.0 milestone May 19, 2014
@skurfer skurfer added the Bug label May 19, 2014
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 19, 2014

Hmmm... I can't reproduce. Running off master (HEAD @ b049daa)

  1. Run "Get File URL" on Finder.app, returns file:///System/Library/CoreServices/Finder.app/
  2. Dismiss the interface (I'm using Mini interface)
  3. Use my ⌘⌥⌃. trigger to bring up the iTunes 'Search Artist' trigger
  4. Type "Britney Spears"
  5. Searching works fine, but unfortunately I have no Britney in my Library :'(

@skurfer
Copy link
Member Author

@skurfer skurfer commented May 19, 2014

These things work fine with a single selection, but try “Get File URL” on both Finder and Safari or something…

screen shot 2014-05-19 at 8 19 39 am

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 19, 2014

OK, confirmed. Finder hangs around as a comma’ed object.

Have you run a git bisect yet? I’ll do one tomorrow if now.

On 19 Mai 2014, at 19:20, Rob McBroom notifications@github.com wrote:

These things work fine with a single selection, but try “Get File URL” on both Finder and Safari or something…


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member Author

@skurfer skurfer commented May 19, 2014

No bisect yet. I’ve been seeing the trigger thing for quite some time, just didn’t get around to reporting it.

@skurfer
Copy link
Member Author

@skurfer skurfer commented May 20, 2014

Found it with an educated guess, not a bisect, so I could be wrong, but I’m pretty sure it’s from #1772.

That would also explain another issue that I thought could be my imagination (but isn’t). I kept losing the ability to go back in the history. It’s because clearAll wipes it out.

I haven’t had time to find the exact right combination, but I know we need a call to clearObjectValue somewhere but we do not want to call clearAll. I might be able to look tomorrow.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 20, 2014

Yep, you were right on that guess.

I’m writing some unit tests that test both this thing that was re-broken, and the thing that #1772 was meant to fix, so we can be sure they’re both working.

On 20 Mai 2014, at 10:49, Rob McBroom notifications@github.com wrote:

Found it with an educated guess, not a bisect, so I could be wrong, but I’m pretty sure it’s from #1772.

That would also explain another issue that I thought could be my imagination (but isn’t). I kept losing the ability to go back in the history. It’s because clearAll wipes it out.

I haven’t had time to find the exact right combination, but I know we need a call to clearObjectValue somewhere but we do not want to call clearAll. I might be able to look tomorrow.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants