-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The first pane isn’t always cleared correctly #1846
Comments
Hmmm... I can't reproduce. Running off master (HEAD @ b049daa)
|
OK, confirmed. Finder hangs around as a comma’ed object. Have you run a git bisect yet? I’ll do one tomorrow if now. On 19 Mai 2014, at 19:20, Rob McBroom notifications@github.com wrote:
|
No bisect yet. I’ve been seeing the trigger thing for quite some time, just didn’t get around to reporting it. |
Found it with an educated guess, not a bisect, so I could be wrong, but I’m pretty sure it’s from #1772. That would also explain another issue that I thought could be my imagination (but isn’t). I kept losing the ability to go back in the history. It’s because I haven’t had time to find the exact right combination, but I know we need a call to |
Yep, you were right on that guess. I’m writing some unit tests that test both this thing that was re-broken, and the thing that #1772 was meant to fix, so we can be sure they’re both working. On 20 Mai 2014, at 10:49, Rob McBroom notifications@github.com wrote:
|
It looks like #203 and something similar to #670 are back.
Select multiple files with the comma trick. The selection isn’t cleared in either of these scenarios:
The text was updated successfully, but these errors were encountered: