Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can’t right-arrow into symbolic links #1884

Closed
skurfer opened this issue Jun 23, 2014 · 5 comments
Closed

Can’t right-arrow into symbolic links #1884

skurfer opened this issue Jun 23, 2014 · 5 comments
Assignees

Comments

@skurfer
Copy link
Member

skurfer commented Jun 23, 2014

This works in 1.1.3. I ran ln -s /usr/local/src in my home directory. Right-arrowing fails with this error on the console.

2014/06/23 9:23:48.049 AM Quicksilver[29698]: Error loading files: Error Domain=NSCocoaErrorDomain Code=256 "The file “src” couldn’t be opened." UserInfo=0x600001664140 {NSURL=/Users/rob/src, NSFilePath=/Users/rob/src, NSUnderlyingError=0x600001052e10 "The operation couldn’t be completed. Not a directory"}

I think we’re testing isAlias when loading children, but not doing anything to check for symlinks.

I briefly looked into it and I think part of the problem could be that symlinks aren’t being detected correctly. For example, when figuring out what to show for the details string, the fileUTI for a symlink always comes back as the UTI for the target file.

@skurfer skurfer added this to the 1.2.0 milestone Jun 23, 2014
@skurfer skurfer added the Bug label Jun 23, 2014
@pjrobertson
Copy link
Member

pjrobertson commented Jul 23, 2014

I can reproduce this problem in 1.1.0 (there's no tag for 1.1.3)

Obviously this is a bug, but are you sure it's v1.2 related?
Also, under v1.1 or v1.2 I don't see that error in Console or Xcode.

@skurfer
Copy link
Member Author

skurfer commented Jul 23, 2014

I can reproduce this problem in 1.1.0 (there's no tag for 1.1.3)

No tag, but if you check out the v1.1.x branch, that should give you 1.1.3. (Remember, that branch has to live on independently because it has a lot of the same commits as master cherry-picked into it.)

Obviously this is a bug, but are you sure it's v1.2 related?

Since there have been a number of changes to how symlinks are handled, and since the problem seems to be with detecting the right UTI… no I’m not sure, but I’m pretty sure. 😃

I was planning to look at this, but haven’t had time. Feel free if you can.

@pjrobertson
Copy link
Member

pjrobertson commented Jul 30, 2014

I just don't think it's v1.2 related, so my arguments that this shouldn't be a v1.2 showstopper... ;-)

@skurfer
Copy link
Member Author

skurfer commented Jul 30, 2014

Perhaps. A stronger argument (that I’ve considered making myself) is that this isn’t that big a deal. 😃 Not worth holding back a release at this point.

@skurfer skurfer removed this from the 1.2.0 milestone Jul 30, 2014
skurfer added a commit that referenced this issue Aug 2, 2014
@skurfer skurfer self-assigned this Jun 26, 2015
@skurfer
Copy link
Member Author

skurfer commented Nov 14, 2015

Fixed by #2142

@skurfer skurfer closed this as completed Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants