Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputing capital letters with applescript will trigger QS if double-shift activation is set #1950

Closed
Commandor opened this issue Oct 17, 2014 · 6 comments · Fixed by #1969
Closed

Comments

@Commandor
Copy link

Commandor commented Oct 17, 2014

As title, when input two (or more) capital letters in a row with applescript, QS will be activated with double-shift activation is set, but the rest strings could still be input behind the QS window. This only happens after 400E, including 400F, it was not activated this way in 4007. Thanks in advance.

@philostein
Copy link
Contributor

philostein commented Oct 17, 2014

Inputing capital letters into where? Quicksilver's 1st pane?

@Commandor
Copy link
Author

Commandor commented Oct 17, 2014

I use that to switch iTunes store, input different apple id and password.

@skurfer
Copy link
Member

skurfer commented Oct 17, 2014

Can you post some example AppleScript? (Definitely don’t include the script that types your password.)

@Commandor
Copy link
Author

Commandor commented Oct 17, 2014

There are two capital letters in my password.

When I use double-shift, QS will be triggered, but not with double-command.

tell application "System Events"
tell process "iTunes"
set frontmost to true
try
click menu item "登出" of menu "商店" of menu bar item "商店" of menu bar 1
end try
delay 1
click menu item "登入⋯" of menu "商店" of menu bar item "商店" of menu bar 1
delay 1
keystroke "Apple ID"
keystroke tab
keystroke "PASSWORD"
keystroke return
end tell
end tell

@pjrobertson
Copy link
Member

pjrobertson commented Nov 1, 2014

I think this probably is a bug with QS. Even using an AppleScript like:

tell application "System Events"
    keystroke "Big"
    key down command
    key up command
    keystroke "Ben"
end tell

and double-shift activation, QS is activated. Maybe AS isn't sending the events through?

pjrobertson added a commit that referenced this issue Nov 1, 2014
If a different modifier was pressed between two 'activation modifier' key presses, QS could still be activated.
E.g. in a 'double shift activation' scenario, if ⇪⌥⇧ was pressed, QS would still activate.
This change ensures that the state of any modifier events is reset when any non-related keys are pressed.

Fixes #1950
pjrobertson added a commit that referenced this issue Nov 1, 2014
If a different modifier was pressed between two 'activation modifier' key presses, QS could still be activated.
E.g. in a 'double shift activation' scenario, if ⇪⌥⇧ was pressed, QS would still activate.
This change ensures that the state of any modifier events is reset when any non-related keys are pressed.

Fixes #1950
@pjrobertson
Copy link
Member

pjrobertson commented Nov 1, 2014

You can also reproduce this by setting hotkey activation to double shift, then pressing:

⇧⌥⇧ in quick succession.
See #1969 for a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants