Skip to content

Code style #2050

@tiennou

Description

@tiennou

I'm filing a new issue so we can discuss that ;-). I'm investigating some style guide I'd like us to all use when coding. @skurfer told me we preferred 4 spaces, so I went along and built a quick Ruby script so I could be sure we were going the right way.

Here's the script : https://gist.github.com/tiennou/4a4561e55050234b0031
The results of ./indent-stat.rb "*.[hm]" are {:files=>562, :tabs=>29451, :spaces=>16996}.

That's 63% tabs. This means I'd like to switch to tabs because there's almost 2 times more lines that begin with those.

And then I'd propose going setting that style as "canonical", with an exemption w.r.t to us using tabs for indent.

Some insight on the tab/space wars : 1 + followup.

There's also a bunch of links at the end of the style guide above which points to more style guides. Feel free to take a look at them, but I just took the first one I found that looked like something I'd want to enforce.

Fun fact: our "Initial commit to GC" is {:files=>713, :tabs=>35909, :spaces=>19675}. That's 64% tabs. I'll let you guess which commit caused a drop of almost 200 files ;-).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions