You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I’ve seen this in the Console for months and finally looked into it.
CoreAnimation: warning, deleted thread with uncommitted CATransaction
It’s because running actions and scanning the catalog happen on background threads. I found three specific places to fix, but I’m sure there are others:
-[QSInterfaceController showArray:withDirectObject:] calls setSearchMode, which updates the UI. (I think there are other things in there besides setSearchMode we should worry about though.)
-[QSSearchObjectView hideResultsView:]
-[QSLibrarian scanCatalogIgnoringIndexes:] manipulates the progress for a task which, via KVO, eventually causes the UI to get updated. I’m not sure how to fix this one. The thing doing the observing appears to be on the same thread as the catalog scan, which shouldn’t necessarily be the case. Maybe there’s some way to make sure the objects observing “progress” are always on the main thread? Fixing this will probably also fix Crash related to the QSTask cleanup #2261.
-[QSTask updateTaskView] is run asynchronously. I think I got rid of a warning by making it synchronous.
Just making a note of these for now, since a pull request would have conflicts (and I’m not sure how to fix 3 anyway.)
The text was updated successfully, but these errors were encountered:
I’ve seen this in the Console for months and finally looked into it.
It’s because running actions and scanning the catalog happen on background threads. I found three specific places to fix, but I’m sure there are others:
-[QSInterfaceController showArray:withDirectObject:]
callssetSearchMode
, which updates the UI. (I think there are other things in there besidessetSearchMode
we should worry about though.)-[QSSearchObjectView hideResultsView:]
-[QSLibrarian scanCatalogIgnoringIndexes:]
manipulates theprogress
for a task which, via KVO, eventually causes the UI to get updated. I’m not sure how to fix this one. The thing doing the observing appears to be on the same thread as the catalog scan, which shouldn’t necessarily be the case. Maybe there’s some way to make sure the objects observing “progress” are always on the main thread? Fixing this will probably also fix Crash related to the QSTask cleanup #2261.-[QSTask updateTaskView]
is run asynchronously. I think I got rid of a warning by making it synchronous.Just making a note of these for now, since a pull request would have conflicts (and I’m not sure how to fix 3 anyway.)
The text was updated successfully, but these errors were encountered: