Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core animation warnings about transactions #2275

Closed
skurfer opened this issue Sep 21, 2016 · 1 comment
Closed

Core animation warnings about transactions #2275

skurfer opened this issue Sep 21, 2016 · 1 comment

Comments

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 21, 2016

I’ve seen this in the Console for months and finally looked into it.

CoreAnimation: warning, deleted thread with uncommitted CATransaction

It’s because running actions and scanning the catalog happen on background threads. I found three specific places to fix, but I’m sure there are others:

  1. -[QSInterfaceController showArray:withDirectObject:] calls setSearchMode, which updates the UI. (I think there are other things in there besides setSearchMode we should worry about though.)
  2. -[QSSearchObjectView hideResultsView:]
  3. -[QSLibrarian scanCatalogIgnoringIndexes:] manipulates the progress for a task which, via KVO, eventually causes the UI to get updated. I’m not sure how to fix this one. The thing doing the observing appears to be on the same thread as the catalog scan, which shouldn’t necessarily be the case. Maybe there’s some way to make sure the objects observing “progress” are always on the main thread? Fixing this will probably also fix #2261.
  4. -[QSTask updateTaskView] is run asynchronously. I think I got rid of a warning by making it synchronous.

Just making a note of these for now, since a pull request would have conflicts (and I’m not sure how to fix 3 anyway.)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 4, 2022

I used to see this when running QS, but not anymore. Apple changed their implementation, or it was already fixed?

@skurfer - please close if you agree :)

@skurfer skurfer closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants