Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Manipulation PlugIn BUG #2300

Closed
Kethal opened this issue Dec 31, 2016 · 8 comments · Fixed by #2304
Closed

Image Manipulation PlugIn BUG #2300

Kethal opened this issue Dec 31, 2016 · 8 comments · Fixed by #2304

Comments

@Kethal
Copy link

@Kethal Kethal commented Dec 31, 2016

Dear Support, please note that after new update of QuickSilver I face a specific bug. Whenevery I make a screenshot via Image Manipulation PlugIn, the Quicksilver window remains on the screenshot (while in previous versions this Quicksilver window was hidden during screenshot snapping). See example attached
screen region 2016-12-31 at 18 57 11
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 1, 2017

@Kethal
Copy link
Author

@Kethal Kethal commented Jan 1, 2017

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 1, 2017

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 1, 2017

Seems the bad commit is 2b2cc2d
@tiennou is the culprit!

Etienne - do you know what's going on here/any idea how to fix this?

@tiennou
Copy link
Member

@tiennou tiennou commented Jan 1, 2017

That's, well, convoluted. IIRC, what happens is that because of the clear-last-search changes (aeaa261), the dSelector has no string, hence this (2b2cc2d#diff-67e3a94a52a5e4a92915f1f10797045bL655) saves nothing, hence the mnemonics aren't updated.

But moving that (!cont) test makes the screenshot happen before we hide the main window, hence this bug 😠.

Maybe make the take screenshot action main-thread only ? That should queue the action in the next runloop instead of going through a background queue, which would allow the current runloop to complete and thus hide the window ?

@pjrobertson pjrobertson mentioned this issue Jan 2, 2017
Closed
pjrobertson added a commit that referenced this issue Jan 3, 2017
@pjrobertson
Another go at ensuring search string is cleared when closing interface
7143b83 
The problem is that clearing the search string too early means mnemonics are not saved, so if we move the mnemonic saving code earlier this fixes it.
The reason we want to clear the search string on interface close is a UI thing. See this comment: #2249
Fixes #2302
Fixes #2300
Related to #2268 #2269
@pjrobertson pjrobertson mentioned this issue Jan 3, 2017
Merged
@skurfer skurfer mentioned this issue Jan 9, 2017
Closed
@Kethal
Copy link
Author

@Kethal Kethal commented Jan 17, 2017

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 18, 2017

It's been fixed and will be out included in a new release soon. In the meantime you can downgrade to an earlier version of QS or wait it out for the new release!

@Kethal
Copy link
Author

@Kethal Kethal commented Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Another go at ensuring search string is cleared when closing interface quicksilver/Quicksilver
3 participants
@tiennou @pjrobertson @Kethal