displaysResult is ignored for some actions

[skurfer]

Most easily reproduced with the Calculator module.

Expected default behavior:

1. invoke QS
2. type = to get text input
3. enter valid expression
4. type ↩ to perform calculation
5. bezel remains displayed with result in first pane
   (6. result is available for other QS actions i.e. ⌘C copies result
   to clipboard)

Current default behavior:

1. invoke QS
2. type = to get text input
3. enter valid expression
4. type ↩ to perform calculation
5. bezel disappears
6. user must invoke QS again to see result

This also happens with the various “Get XYZ URL” actions in the Remote Hosts module, but only if you call it as an alternate action via ⌘↩. If you run those actions directly, the interface is redisplayed correctly.

[ghost]

the calculator works as how you'd expect it to work up until step 5 with this fix: 39e4880
it should probably select the first pane as well, which would be step 6.

[skurfer]

I’ve tracked this to QSInterfaceController.m:483

if ([action isKindOfClass:[QSRankedObject class]] && [(QSRankedObject *)action object])

Need to figure out what that’s testing for.

UPDATE: I guess I should have just looked at the commit you linked. :) Should it be more like this?

if (action) {
    if ([action isKindOfClass:[QSRankedObject class]] && [(QSRankedObject *)action object]) {
        QSAction* rankedAction = [(QSRankedObject *)action object];
        if (rankedAction != action) {
            [rankedAction retain];
            [action release];
            action = rankedAction;
        }
    }
    if ([action displaysResult]) {
        [self showMainWindow:self];
    }
}

Since the showMainWindow is going to be unconditional, we should only have it in there once and this will make sure it runs after the rankedAction stuff like it does now (in case that matters). I’ll implement and test on my fork, but wanted your opinion.