Recent Documents are broken under High Sierra

[skurfer]

Once again, we’ll have to figure out how to get this working.

The Console just shows <private>. I’m sure this is just Apple’s way of saying “use the public API instead”, right?

[skurfer]

Of course the Xcode console has a bit more to say:

2017-09-26 16:19:18.972723-0400 Quicksilver[35769:1443206] [General] *** -[NSKeyedUnarchiver decodeObjectForKey:]: cannot decode object of class (SFLListItem) for key (NS.objects); the class may be defined in source code or a library that is not linked
2017-09-26 16:19:18.974290-0400 Quicksilver[35769:1443206] [General] (
	0   CoreFoundation                      0x00007fff328f20fb __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x00007fff591dec76 objc_exception_throw + 48
	2   Foundation                          0x00007fff34a1b23f -[NSCoder(Exceptions) __failWithExceptionName:errorCode:format:] + 0
	3   Foundation                          0x00007fff34a1b3bc -[NSCoder(Exceptions) __failWithExceptionName:errorCode:format:] + 381
	4   Foundation                          0x00007fff34906474 _decodeObjectBinary + 2856
	5   Foundation                          0x00007fff34907510 -[NSKeyedUnarchiver _decodeArrayOfObjectsForKey:] + 1779
	6   Foundation                          0x00007fff3490b367 -[NSArray(NSArray) initWithCoder:] + 202
	7   Foundation                          0x00007fff349062c1 _decodeObjectBinary + 2421
	8   Foundation                          0x00007fff34907510 -[NSKeyedUnarchiver _decodeArrayOfObjectsForKey:] + 1779
	9   Foundation                          0x00007fff34906934 -[NSDictionary(NSDictionary) initWithCoder:] + 202
	10  Foundation                          0x00007fff349062c1 _decodeObjectBinary + 2421
	11  Foundation                          0x00007fff34905848 _decodeObject + 243
	12  Foundation                          0x00007fff349b0144 +[NSKeyedUnarchiver unarchiveObjectWithFile:] + 148
	13  QSCore                              0x00000001004ac037 recentDocumentsForBundle + 423
	14  QSCore                              0x00000001004b04be -[QSFileSystemObjectHandler loadChildrenForObject:] + 2894
	15  QSCore                              0x00000001004a7bed -[QSObject(Hierarchy) loadChildren] + 93
	16  QSCore                              0x00000001004a85cd -[QSObject(Accessors) children] + 93
	17  QSInterface                         0x00000001005bf6c6 -[QSSearchObjectView(Browsing) browse:] + 342
	18  QSInterface                         0x00000001005bf4f7 -[QSSearchObjectView(Browsing) moveRight:] + 103
	19  QSInterface                         0x00000001005ba7a7 -[QSSearchObjectView handleSlashEvent:] + 279
	20  QSInterface                         0x00000001005b9ac3 -[QSSearchObjectView keyDown:] + 627
	21  AppKit                              0x00007fff307bc915 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 5040
	22  AppKit                              0x00007fff307bb148 -[NSWindow(NSEventRouting) sendEvent:] + 497
	23  QSEffects                           0x000000010045c83c -[QSWindow sendEvent:] + 1004
	24  AppKit                              0x00007fff3061c95f -[NSApplication(NSEvent) sendEvent:] + 2751
	25  Quicksilver                         0x0000000100002778 -[QSApp sendEvent:] + 2440
	26  AppKit                              0x00007fff2fe7e28d -[NSApplication run] + 812
	27  AppKit                              0x00007fff2fe4d3fe NSApplicationMain + 804
	28  Quicksilver                         0x000000010002b3a3 main + 195
	29  libdyld.dylib                       0x00007fff59dcd145 start + 1
	30  ???                                 0x0000000000000003 0x0 + 3
)

[skurfer]

So, it seems like this one-liner should fix it

[NSKeyedUnarchiver setClass:[SFLListItem class] forClassName:@"SFLListItem"];

but the build fails.

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_SFLListItem", referenced from:
      objc-class-ref in QSObject_FileHandling.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The header is included in QSFoundation, so I’m not sure what to make of this.

[tiennou]

It means the linker cannot resolve the needed reference from anything we link to.

Looking at the header, I guess /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList (which we ought to pull in because CoreServices) doesn't define that class anymore, or it was moved somewhere else.

[pjrobertson]

The SFLListItem is a private class that I got with ‘classdump’ and pulled it into the QS Code. No wonder it’s broken, they’ve most likely changed the interface in High Sierra. Look at ‘SFLListItem.h’ for more details. There’s some info in the header: ``` // // SFLListItem.h // Quicksilver // // Created by Patrick Robertson on 30/01/2016. // // // Original source code form: http://pastebin.com/dYxrGX7c <http://pastebin.com/dYxrGX7c> #import <Foundation/Foundation.h> // // Generated by class-dump 3.5 (64 bit). // // class-dump is Copyright (C) 1997-1998, 2000-2001, 2004-2015 by Steve Nygard. // // Generated from /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList ```

…

On 27 Medi 2017, at 03:20, Rob McBroom ***@***.*** ***@***.***>> wrote: Once again, we’ll have to figure out how to get this working. The Console just shows <private>. I’m sure this is just Apple’s way of saying “use the public API instead”, right? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2396>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJLn8iRGZD0UBAkzUZzeeOHdZ01ObMwks5smU6QgaJpZM4PkwCB>.

[skurfer]

The SFLListItem is a private class that I got with ‘classdump’ and pulled it into the QS Code.
No wonder it’s broken, they’ve most likely changed the interface in High Sierra.

Yeah, I saw that. From recently updated .sfl files, it doesn’t look like the interface or class name has changed. It’s just not there any more. class-dump no longer shows any mention of that class. I also tried checking otool -L SharedFileList to see if it could be getting included from another file. No luck finding it. Any other ideas?

[tiennou]

Does nm reports interesting (C) symbols maybe ? It really seems like that class is no more on High Sierra…

[skurfer]

I found a fix for this. The items are just dictionaries now and we can get the data using the public API for NSURL.

A pull request is coming, but I want to try to fix one last thing: URLs for Recent/Favorite Servers don’t get resolved unless the filesystem is currently mounted. (The NSURLBookmarkResolutionWithoutMounting doesn’t seem to make a difference.)

[pjrobertson]

Awesome, nice work! What do we do about backwards compatibility? Just use an `if (isHighSierra) {}` block?

…

On 16 Hyd 2017, at 10:53, Rob McBroom ***@***.***> wrote: I found a fix for this. The items are just dictionaries now and we can get the data using the public API for NSURL. A pull request is coming, but I want to try to fix one last thing: URLs for Recent/Favorite Servers don’t get resolved unless the filesystem is currently mounted. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2396 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJLnw9iVdhebR8fkAR_nYVs8xG4XuLtks5sssU6gaJpZM4PkwCB>.

[skurfer]

Yeah, that’s what I did. I think we have three different techniques in there for different OS versions now.