New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent Documents are broken under High Sierra #2396
Comments
Of course the Xcode console has a bit more to say:
|
So, it seems like this one-liner should fix it
but the build fails.
The header is included in |
It means the linker cannot resolve the needed reference from anything we link to. Looking at the header, I guess |
The SFLListItem is a private class that I got with ‘classdump’ and pulled it into the QS Code.
No wonder it’s broken, they’ve most likely changed the interface in High Sierra.
Look at ‘SFLListItem.h’ for more details. There’s some info in the header:
```
//
// SFLListItem.h
// Quicksilver
//
// Created by Patrick Robertson on 30/01/2016.
//
//
// Original source code form: http://pastebin.com/dYxrGX7c <http://pastebin.com/dYxrGX7c>
#import <Foundation/Foundation.h>
//
// Generated by class-dump 3.5 (64 bit).
//
// class-dump is Copyright (C) 1997-1998, 2000-2001, 2004-2015 by Steve Nygard.
//
// Generated from /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList
```
… On 27 Medi 2017, at 03:20, Rob McBroom ***@***.*** ***@***.***>> wrote:
Once again, we’ll have to figure out how to get this working.
The Console just shows <private>. I’m sure this is just Apple’s way of saying “use the public API instead”, right?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#2396>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJLn8iRGZD0UBAkzUZzeeOHdZ01ObMwks5smU6QgaJpZM4PkwCB>.
|
Yeah, I saw that. From recently updated |
Does |
I found a fix for this. The items are just dictionaries now and we can get the data using the public API for A pull request is coming, but I want to try to fix one last thing: URLs for Recent/Favorite Servers don’t get resolved unless the filesystem is currently mounted. (The |
Awesome, nice work! What do we do about backwards compatibility? Just use an `if (isHighSierra) {}` block?
… On 16 Hyd 2017, at 10:53, Rob McBroom ***@***.***> wrote:
I found a fix for this. The items are just dictionaries now and we can get the data using the public API for NSURL.
A pull request is coming, but I want to try to fix one last thing: URLs for Recent/Favorite Servers don’t get resolved unless the filesystem is currently mounted.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#2396 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJLnw9iVdhebR8fkAR_nYVs8xG4XuLtks5sssU6gaJpZM4PkwCB>.
|
Yeah, that’s what I did. I think we have three different techniques in there for different OS versions now. |
Once again, we’ll have to figure out how to get this working.
The Console just shows
<private>
. I’m sure this is just Apple’s way of saying “use the public API instead”, right?The text was updated successfully, but these errors were encountered: