Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent documents via right arrow not working on High Sierra #2431

Closed
rosano opened this issue Mar 6, 2018 · 21 comments
Closed

Recent documents via right arrow not working on High Sierra #2431

rosano opened this issue Mar 6, 2018 · 21 comments
Assignees
Labels

Comments

@rosano
Copy link

@rosano rosano commented Mar 6, 2018

I found this thread https://groups.google.com/forum/#!msg/blacktree-quicksilver/ccEoDmZMU3k/nhLiWB50BAAJ after experiencing the same issue and I tried Rob's first suggestion to replicate the bug. Here's a short video https://www.dropbox.com/s/ugbz1cr94k7ra2a/1%20replicate.mp4?dl=0

  • I made a new user account
  • opened 4 PDFs
  • confirmed they were in the Open Recent menu item of Preview
  • tried to access them from QS via right arrow on Preview (in the video there is no visual feedback when the right arrow doesn't work, but I had pressed it several times)

When it worked in the past I think there used to be a disclosure arrow on the selected application (if it had recent documents), but now there isn't one.

I am using QS 1.5.8 on High Sierra 10.13.3

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 7, 2018

Try this custom build of the app. It’s identical to the current release, but I’ve added some logging in the recent documents code. Look in the console for lines containing “GET_RECENTS”.

https://cl.ly/2A1x0j190N42

@mdaeron
Copy link

@mdaeron mdaeron commented Mar 7, 2018

Should I look in any particular log file? I just launched your build, tried accessing recent documents from several applications by using right-arrow, then opened Console.app and looked for 'GET_RECENTS', which yields no results.

temp

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 8, 2018

You’re looking in the right place. That makes me think it never even gets to the part that loads recent documents. Here’s another test build with logging further up in the code. Look for “ISSUE2431” this time.

https://cl.ly/2p1b101H020X

I made sure it was signed this time so you won’t get the “unknown developer” warning.

@mdaeron
Copy link

@mdaeron mdaeron commented Mar 8, 2018

Just tried. Again, nothing shows up when searching "ISSUE2431".

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 8, 2018

What if you try right-arrowing into a folder? First, does it work as expected? And if so, do you see anything in the console?

@rosano
Copy link
Author

@rosano rosano commented Mar 8, 2018

I haven't been able to test the build yet, but I can confirm that in the public release right-arrowing into a folder works as expected, but I don't see anything in the console.

@mdaeron
Copy link

@mdaeron mdaeron commented Mar 8, 2018

Same here. Right-arrowing into folders always works, right-arrowing into application never does.

No "ISSUE2431" in the console in either case.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 8, 2018

If I right-arrow into downloads with that test build, I see

default	11:57:27.613787 -0500	Quicksilver	ISSUE2431 load children
default	11:57:27.613888 -0500	Quicksilver	ISSUE2431 single file: /Users/rob/Downloads
default	11:57:27.613929 -0500	Quicksilver	ISSUE2431 this is a directory

If it’s working, you should see something.

@mdaeron
Copy link

@mdaeron mdaeron commented Mar 8, 2018

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 8, 2018

OK. What do you see when right-arrowing into an application?

@mdaeron
Copy link

@mdaeron mdaeron commented Mar 8, 2018

@rosano
Copy link
Author

@rosano rosano commented Mar 8, 2018

I tried manually navigating from the Applications folder with Quicksilver and did not see any log when right-arrowing into Preview, but there was a disclosure arrow for Quicksilver and there was a log when right-arrowing:

default	15:07:41.438307 -0500	Quicksilver	ISSUE2431 load children
default	15:07:41.438415 -0500	Quicksilver	ISSUE2431 single file: /Applications
default	15:07:41.438479 -0500	Quicksilver	ISSUE2431 this is a directory
default	15:08:11.150098 -0500	Quicksilver	ISSUE2431 load children
default	15:08:11.150203 -0500	Quicksilver	ISSUE2431 single file: /Applications/Quicksilver.app
default	15:08:11.150267 -0500	Quicksilver	ISSUE2431 this is a directory
default	15:08:11.151253 -0500	Quicksilver	ISSUE2431 this is an application
default	15:08:11.151334 -0500	Quicksilver	ISSUE2431 found child preset: QSPresetQSCatalogEntries

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 9, 2018

OK. Here’s another build with more logging.

https://cl.ly/1M3Y2w1h1M1B

If anyone has Xcode and would be willing to troubleshoot that way, this might go faster. (I would provide more detail about where and what to look for.)

@mdaeron
Copy link

@mdaeron mdaeron commented Mar 9, 2018

Now when I type 'prev' for Preview, here's what I get:

default	15:06:54.989353 +0100	Quicksilver	ISSUE2431 checking Preview.app for children
default	15:06:54.992468 +0100	Quicksilver	ISSUE2431 checking A Compact Underwater Vehicle: The Nanoseeker | Hackaday for children
default	15:06:54.994543 +0100	Quicksilver	ISSUE2431 checking ImageCaptureService.app for children
default	15:06:54.995181 +0100	Quicksilver	ISSUE2431 checking SpeechService.service.app for children
default	15:06:54.997070 +0100	Quicksilver	ISSUE2431 checking SpeechRecognitionServer.app for children
default	15:06:54.997733 +0100	Quicksilver	ISSUE2431 checking Desktop & Screen Saver for children
default	15:06:55.083654 +0100	Quicksilver	ISSUE2431 checking Preview.app for children
default	15:06:59.317249 +0100	Quicksilver	ISSUE2431 right arrow
default	15:06:59.317312 +0100	Quicksilver	ISSUE2431 checking Preview.app for children
default	15:06:59.324765 +0100	Quicksilver	ISSUE2431 checking Preview.app for children
default	15:06:59.327498 +0100	Quicksilver	ISSUE2431 checking A Compact Underwater Vehicle: The Nanoseeker | Hackaday for children
default	15:06:59.330365 +0100	Quicksilver	ISSUE2431 checking ImageCaptureService.app for children
default	15:06:59.331347 +0100	Quicksilver	ISSUE2431 checking SpeechService.service.app for children
default	15:06:59.333835 +0100	Quicksilver	ISSUE2431 checking SpeechRecognitionServer.app for children
default	15:06:59.334523 +0100	Quicksilver	ISSUE2431 checking Desktop & Screen Saver for children
default	15:06:59.386787 +0100	Quicksilver	ISSUE2431 checking Preview.app for children
default	15:06:59.401068 +0100	Quicksilver	ISSUE2431 checking A Compact Underwater Vehicle: The Nanoseeker | Hackaday for children
default	15:06:59.403131 +0100	Quicksilver	ISSUE2431 checking ImageCaptureService.app for children
default	15:06:59.403766 +0100	Quicksilver	ISSUE2431 checking SpeechService.service.app for children
default	15:06:59.405705 +0100	Quicksilver	ISSUE2431 checking SpeechRecognitionServer.app for children
default	15:06:59.406387 +0100	Quicksilver	ISSUE2431 checking Desktop & Screen Saver for children

So Quicksilver is detecting my right arrow, but not acting on it, I guess.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 11, 2018

I’ve added more logging to a different place, but in the process might have found the problem.

https://cl.ly/282w421u3X04

Let me know if it suddenly works, and if so, which interface you use because I can’t think of any other explanation for why it would only be broken for some people.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 11, 2018

New theory: Those of us that still have all the .sfl files laying around from older OSes pass the “has recent documents” test, but freshly installed systems will only have .sfl2 files and QS won’t think it has children.

skurfer added a commit that referenced this issue Mar 11, 2018
@rosano
Copy link
Author

@rosano rosano commented Mar 11, 2018

Seems to work for me! Preview, Numbers, Pages - all showing recent documents now.

@mdaeron
Copy link

@mdaeron mdaeron commented Mar 11, 2018

Same here. This seems to solve the problem for me.
Thanks to rosano for reviving the issue, and to skurfer for taking the time to work on it.

@mdaeron
Copy link

@mdaeron mdaeron commented Mar 11, 2018

Addendum: for some reason (non-standard API probably?) it still doesn't work for BBEdit. Not a deal breaker as far as I'm concerned, but I thought I should mention it.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 12, 2018

I’ve released Quicksilver 1.5.9 which should fix this (without all the logging). I’m not sure what’s going on with BBEdit. It’s hard to imagine they’d do something non-standard, but I don’t know what else would explain it.

@rosano
Copy link
Author

@rosano rosano commented Mar 12, 2018

Official release works great - Thank you Rob for fixing it so quickly and on a weekend! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants