Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggers not saved when editing in sidebar #248

Closed
pjrobertson opened this issue Apr 24, 2011 · 1 comment · Fixed by #461
Closed

Triggers not saved when editing in sidebar #248

pjrobertson opened this issue Apr 24, 2011 · 1 comment · Fixed by #461
Assignees
Labels

Comments

@pjrobertson
Copy link
Member

Go ahead and add

    NSLog(@"writing triggers");

to QSTriggerCenter.m:181

It'll tell you when the triggers are going to get written to the .plist.

Go into QS and have a play with the triggers. You'll see that the ONLY place triggers get saved to the .plist is when you
a) Create a new trigger
b) select another trigger in the list

Basically, anything you do in the sidebar (except setting the hotkey) doesn't get written anywhere. You have to click on say another trigger to save it.

I'm posting this here since I don't know enough about NSViews and stuff.

I had a quick look into it and thought you could either set an observer for when the sidebar lost focus

        [[NSNotificationCenter defaultCenter] addObserver:drawerView selector:@selector(triggerChanged:) name:NSViewFrameDidChangeNotification object:nil];

I can't seem to get that to work

Or add notifications to the text fields to 'writeTriggers' when text is entered using

 - (void) textDidChange: (NSNotification *) notification

I don't know enough about these to implement it.

@ghost ghost assigned pjrobertson Jul 18, 2011
pjrobertson added a commit to pjrobertson/Quicksilver that referenced this issue Jul 18, 2011
@pjrobertson
Copy link
Member Author

This has been 'fixed' by saving triggers when the refs page is closed.

It seems extremely difficult to enable this for all buttons - unless there's somebody especially familiar with Interface Builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant