Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Quicksilver crashes after using the Large Type feature and dismissing the window.
Crash file attached.
Steps to reproduce the behavior:
Quicksilver should not crash
If applicable, add screenshots to help explain your problem.
What version of macOS?
What version of Quicksilver?
The text was updated successfully, but these errors were encountered:
The same for me!
MacOS: Catalina (10.15.3)
Version of Quicksilver: 1.6.0
Sorry, something went wrong.
I'm not on Catalina yet, but the QSVanishingWindow code mentioned in the crash log looks iffy. Running stuff in dealloc doesn't seem good. It's originally from these two commits:
First this: 33067ae
Then a 'bug fix': a64a8cc
Yeah, the _largeTypeWindows array is obviously just there to keep the retain count up, but there must be a safer way to accomplish that. I've tried a few things, but either the window never appears, or the app crashes.
Thanks for fixing this!
I just finally realized today that this bug was causing a huge part of what felt like Quicksilver flakiness!
Not sure why I didn't get an auto-update yet, but a manual update fixed it for me. Thanks, @skurfer! 😍
No branches or pull requests