Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after using Large Type #2511

Closed
awdsmirk opened this issue Feb 13, 2020 · 5 comments
Closed

Crash after using Large Type #2511

awdsmirk opened this issue Feb 13, 2020 · 5 comments

Comments

@awdsmirk
Copy link

awdsmirk commented Feb 13, 2020

Quicksilver crashes after using the Large Type feature and dismissing the window.
Crash file attached.
To Reproduce
Steps to reproduce the behavior:

  1. Launch Quicksilver - I am using Bezel (built-in)
  2. Type period character "." to go into text large type mode
  3. Type in any text, hit Enter
  4. Your text is displayed in Large Type on the screen
  5. Dismiss the text by clicking anywhere outside the text
    RESULT: Quicksilver crashes

Expected behavior
Quicksilver should not crash

Screenshots
If applicable, add screenshots to help explain your problem.

What version of macOS?
10.15.3
What version of Quicksilver?
1.6.0
Quicksilver_2020-02-12-222300_deathstar.crash.zip

@jedjds
Copy link

jedjds commented Feb 22, 2020

The same for me!
MacOS: Catalina (10.15.3)
Version of Quicksilver: 1.6.0

@pjrobertson
Copy link
Member

pjrobertson commented May 20, 2020

I'm not on Catalina yet, but the QSVanishingWindow code mentioned in the crash log looks iffy. Running stuff in dealloc doesn't seem good. It's originally from these two commits:

First this: 33067ae
Then a 'bug fix': a64a8cc

@skurfer
Copy link
Member

skurfer commented May 26, 2020

Yeah, the _largeTypeWindows array is obviously just there to keep the retain count up, but there must be a safer way to accomplish that. I've tried a few things, but either the window never appears, or the app crashes.

@awdsmirk
Copy link
Author

awdsmirk commented Aug 4, 2020

Thanks for fixing this!

@lgarron
Copy link
Contributor

lgarron commented Nov 30, 2020

I just finally realized today that this bug was causing a huge part of what felt like Quicksilver flakiness!

Not sure why I didn't get an auto-update yet, but a manual update fixed it for me. Thanks, @skurfer! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants