Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup qsrelease #2581

Closed
7 tasks done
n8henrie opened this issue Nov 13, 2021 · 2 comments
Closed
7 tasks done

Cleanup qsrelease #2581

n8henrie opened this issue Nov 13, 2021 · 2 comments

Comments

@n8henrie
Copy link
Member

n8henrie commented Nov 13, 2021

Since we're relying on qsrelease, I'd like to do a bit of cleanup

  • Add / remove quoting where it could and couldn't make a difference respectively
  • Make POSIX compliant in case MacOS decides to change default shells again
  • More explicit error handling, reporting, and cleanup
  • egrep unneeded for word-boundary regex (supported by /usr/bin/grep without -E on monterey)
  • grep | sed can be simplified with awk
  • add some configuration for local testing (e.g. allow specifying a local cert as a signing identity for testing purposes)
  • prefer --long-arguments for readability

Hopefully the style differences aren't too off-putting, the incoming PR takes suggestions from shellcheck --enable=all --shell=sh

@n8henrie
Copy link
Member Author

Additional issues revealed in this process (present previously but I hadn't noticed in the output, my fault):

@n8henrie
Copy link
Member Author

Closed: #2582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant