Get Current Selection Service no longer works

[skurfer]

Describe the bug

I noticed ⌘⎋ wasn’t working. I checked the Services prefs and saw “033” instead of the expected shortcut. I wiped it and attempted to set it again, but the system doesn’t allow you to use ⎋ in shortcuts. (I don’t remember if it used to.)

Screenshots

What version of macOS?

12.2.1

What version of Quicksilver?

It’s complicated. 😂

[pjrobertson]

#complicated 😆

Works fine on 10.14 for me. Appears to be a regression due to macOS 12 (potentially 11)

[pjrobertson]

At the very least, the timeout shouldn't be 10s, that's way too long in this day and age. Let's make it 3s.

[n8henrie]

Same -- 033 and won't let me use Esc after it's cleared. 12.2.1.

Oddly it still works fine in my stable build of QS -- even with the Keyboard -> Shortcuts option unticked / disabled.

It looks like it's coming from Triggers -> Quicksilver -> Command Window with Selection, which still was showing cmdEsc.

Unfortunately after clearing it, when I try to re-insert Esc, it gives me a 5 instead. ?

EDIT:

This is me trying to re-input cmdEsc on a debug build:

Works fine on stable, I can re-insert cmdEsc without issue.

[pjrobertson]

This is me trying to re-input cmdEsc on a debug build:

Good catch, this is likely an ndhotkey bug. I'll look into it.

The only other change I can think of is the change in 6c5fae9 that jumbled up the plist, but the before and after look the same:

Before:

After:

[n8henrie]

\033 is 27 in octal:

$ py '0o33'
27

27 is the MacOS keycode for escape:

$ grep -i escape /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h
  kEscapeCharCode               = 27,
  kVK_Escape                    = 0x35,

In triggers.plist, the key code for command is:

<integer>1048840</integer>

and b (which I used as an example) is: <integer>11</integer>

>>> int("b", 16)
11
>>> hex(11)
'0xb'
>>> hex(1048840)
'0x100108'

My Triggers.plist has <integer>53</integer> listed for <string>Command Window with Selection</string>

>>> hex(53)
'0x35'

$ grep '35\b' /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h
  kVK_Escape                    = 0x35,

So using Esc as an example, QS is displaying octal format (\033) and storing int format (53) in Triggers.plist; I imagine the 5 I'm seeing in my screenshot above is just a truncation of 53.

[pjrobertson]

I didn't really need to do the git bisect... it just confirmed what we already knew:

64b8a916ae5b9a5d174e4ed6202c7d33111e6d41 is the first bad commit
commit 64b8a916ae5b9a5d174e4ed6202c7d33111e6d41
Author: Patrick Robertson <robertson.patrick@gmail.com>
Date:   Wed Feb 9 10:11:52 2022 +0800

    Ndhotkey fixes (#2594)
    
    * Add NDHotKeyEvent as a submodule.
    
    * Use latest NDHotKeyEvent
    Fixes #2405 Fixes #1134  - #1147 can be closed

I think the fix should be easy - just use ⌘⎋ in the plist.

[pjrobertson]

Yep, just required changing the plist key code to ⎋. Spent ages debugging, even dove into Etienne's code from 8 years ago. These things always end up being so simple.

Will submit a PR