Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-mail actions missing for mailto: strings #267

Closed
skurfer opened this issue Apr 29, 2011 · 4 comments
Closed

E-mail actions missing for mailto: strings #267

skurfer opened this issue Apr 29, 2011 · 4 comments
Assignees
Labels

Comments

@skurfer
Copy link
Member

skurfer commented Apr 29, 2011

If you type, paste, or grab a string from the current application that begins with mailto:, it should be treated as an e-mail address. Currently, the icon changes, but none of the actions that should be available for e-mail addresses are there (such as “Compose Email” and “Email Item…”).

@pjrobertson
Copy link
Member

pjrobertson commented Apr 29, 2011

The line with if([url scheme] ...
in QSObject_StringHandling.m should be changed to then do a check for
if([url scheme] isEqualToString:@"mailto:"...
(and it should be assigned a QSEmailAddressType just as is done a few lines
later down the list.

On 29 April 2011 23:37, skurfer <
reply@reply.github.com>wrote:

If you type, paste, or grab a string from the current application that
begins with mailto:, it should be treated as an e-mail address.
Currently, the icon changes, but none of the actions that should be
available for e-mail addresses are there (such as Compose Email and Email
Item).

Reply to this email directly or view it on GitHub:
#267

@skurfer
Copy link
Member Author

skurfer commented Apr 29, 2011

Does [url scheme] ever evaluate to false? I just noticed that your favorite test case of define:word is now being treated as a URL again and I think it’s because it contains a colon and is matching that line.

@pjrobertson
Copy link
Member

pjrobertson commented Apr 29, 2011

Dammit, you're right.
I'd stuck the [url host] in to make sure that define:word didn't get
evaluated as a URL.
Probably the way to go IS to introduce what I'd previously put in (then
removed) which was a check for a 'mailto:' at the start of the string.

Probably another pull request on string sniffing!

On 30 April 2011 00:48, skurfer <
reply@reply.github.com>wrote:

Does [url scheme] ever evaluate to false? I just noticed that your
favorite test case of define:word is now being treated as a URL again and
I think its because it contains a colon and is matching that line.

Reply to this email directly or view it on GitHub:
#267 (comment)

pjrobertson added a commit to pjrobertson/Quicksilver that referenced this issue Apr 29, 2011
…tions

Also fixes 'define:word' not being a URL
@ghost ghost assigned pjrobertson Apr 29, 2011
skurfer added a commit that referenced this issue Apr 30, 2011
Fixes bug #267; mailto: strings not being given correct actions
@pjrobertson
Copy link
Member

pjrobertson commented Apr 30, 2011

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants