Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quicksilver icon for more sizes #2685

Closed
pjrobertson opened this issue Mar 25, 2022 · 3 comments
Closed

Fix Quicksilver icon for more sizes #2685

pjrobertson opened this issue Mar 25, 2022 · 3 comments
Milestone

Comments

@pjrobertson
Copy link
Member

Some icon sizes are missing in the newest QS icon, created by vadimrob.


From @lgarron:

Would it make sense to add more resolutions to the .icns files?

In #2544 I put a lot of care into the dimensions to match Apple's guidelines/icons, and also to make sure that the horizontal short line at the bottom remains visible in Finder at 1x monitor resolution (right side of screenshot).

Screen Shot 2022-03-16 at 17 41 39

Originally posted by @lgarron in #2595 (comment)

Original .afdesign files are available in that post as well for editing

@lgarron, would you be able to update the icons?

@pjrobertson pjrobertson added this to the 2.1.0 milestone Mar 25, 2022
@lgarron
Copy link
Contributor

lgarron commented Mar 25, 2022

Okay, here's a go that tries to match @vadimrob's design and dimensions. I'll make a PR for it.

icon_16x16
icon_32x32
icon_32x32@2x
icon_128x128
icon_256x256
icon_256x256@2x
icon_512x512@2x

@lgarron
Copy link
Contributor

lgarron commented Mar 25, 2022

(Splitting out into a separate comment for linking.)

If we want a bigger purple surface with a "modern" feel, I'd still be more partial to preserving the traditional Quicksilver style of using a purple inset, also matching current icons for apps like Safari:

icon_512x512@2x

icon_512x512@2x

Screen Shot 2022-03-25 at 05 38 46Screen Shot 2022-03-26 at 01 33 49

But it seems that ship has sailed for now.

@pjrobertson pjrobertson modified the milestones: 2.2.0, 2.1.0 Apr 1, 2022
@pjrobertson
Copy link
Member Author

Fixed by #2686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants