-
Notifications
You must be signed in to change notification settings - Fork 288
[Bug]: Web Searches catalog empty #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's unlikely to be related to the command-line tools, the Web Search plugin isn't connected. Can you please update the original post with a little more information:
Thanks |
@pjrobertson I'm using the Web Search Plugin version 2.9.1. Someone else said it was hanging actually, it's not hanging for me. Here's the output when pressing "Rescan source"
|
I’m seeing this now, so maybe I can debug if I get time tonight. I noticed a few days ago that the list of plug-ins wouldn’t update for me. It’s populated now, but the web searches have gone missing. I wonder if this is related to the switch to |
I’ve seen this now with the release version of 2.0.3. But every local build I make is fine.
The NSURLSession switch was just the Updater stuff so won’t affect this. The Web Searches source uses QSParser’s:
- (NSArray *)objectsFromURL:(NSURL *)url withSettings:(NSDictionary *)settings;
And that hasn’t been touched since 2012.
However, a quick look through QSHTMLLinkParser.m shows that it’s launching a task to run QSURLExtractor.py Perhaps that’s what’s failing - possible that file hasn’t been code-signed so can’t run? (see QSHTMLLinkParser.m:L49)
Seems to me it’d be much simpler to do away with the HTML formatted web searches, and use a JSON dict instead of launching a task to run a python script.
…On 11 Apr 2022, at 22:30, Rob McBroom ***@***.***> wrote:
I’m seeing this now, so maybe I can debug if I get time tonight. I noticed a few days ago that the list of plug-ins wouldn’t update for me. It’s populated now, but the web searches have gone missing. I wonder if this is related to the switch to NSURLSession.
—
Reply to this email directly, view it on GitHub <#2728 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABEXH2LRXI2PKBFEOISRDDVEQZR5ANCNFSM5TAMFXIA>.
You are receiving this because you were mentioned.
|
Uh oh, also working well for me, but I updated @rosano it looks like you're on 10.14? You might not have python3 available (it didn't come in older versions of MacOS by default... on newer versions maybe prompts you to install command line tools if not there?). If you open a terminal prompt and run |
I don't think continuing to support python2 is a great choice, as it's not even getting security patches anymore. https://www.python.org/doc/sunset-python-2/
Also, it looks like MacOS no longer includes python2 by default as of 12.3. On my machine: $ find /usr/bin /bin /usr/sbin -name 'python*' -executable 2>/dev/null
/usr/bin/python3
$ |
A quick way to test if the URL parser is able to run: Enter |
🤦🏻♂️ If I enable those presets before I attempt to rescan, they load just fine. So I can’t reproduce it after all. |
OK, that's a good test. I can confirm that using the Released build (2.0.3) I cannot → into python.org. I'm leaning towards thinking this is a codesigning issue. I will work on implementing QSURLParser.py into pure Obj-c using either this or this |
@rosano - can you please download the following version of Quicksilver, and let us know if it solves the problem: https://github.com/quicksilver/Quicksilver/suites/6092242958/artifacts/211189389 Thanks! |
@pjrobertson still with the same problem, no entries in 'Find with' and here's the log when clicking 're-scan source'
|
Can you please try downloading this version: https://github.com/quicksilver/Quicksilver/suites/6092242473/artifacts/211268363 And confirm you are running the right version by checking the version number in the Quicksilver preferences: Also, please try typing "qsapp.com" into the first pane in Quicksilver, then →. You should get a list of URLs like this: |
@pjrobertson I still can't reproduce on 2.0.3 release (from our publicly released DMG). It takes a second after I hit the arrow, but it works. Looks like @skurfer can't reproduce either. |
Whoops, sorry! I've mistaken, it seems like the searches are there now in this first new version (https://github.com/quicksilver/Quicksilver/suites/6092242958/artifacts/211189389) but maybe after I re-scanned. Also still works after restarting Quicksilver, so it's persisting I guess. 👍🏽 |
So it seems like a 10.14 problem then (the OP is also on 10.14)
Great! As expected, #2729 fixes the problem :) |
Before submitting your bug report, please confirm you have completed the following steps
Bug description
Continuing from https://groups.google.com/g/blacktree-quicksilver/c/SAiNvKCukT8
It seems the Web Searches catalog is empty. When clicking 'Rescan resource' it seems to complete the scan without finding results:
Steps to reproduce
Expected behavior
The options from https://qs0.qsapp.com/plugin-data/web-search-list.php?type=simple should be visible.
MacOS Version
macOS 10.14
Quicksilver Version
2.0.3 (4031)
Crash Logs or Spindump
No response
Screenshots
No response
Additional info
Based on the thread, I wonder if it's a command-line tools issue as I recently removed Xcode from my system. But I'm not clear if it's asking for permission.
The text was updated successfully, but these errors were encountered: