Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit da471f195 breaks compilation on 10.5 #287

Closed
maru-sama opened this issue May 4, 2011 · 2 comments
Closed

Commit da471f195 breaks compilation on 10.5 #287

maru-sama opened this issue May 4, 2011 · 2 comments

Comments

@maru-sama
Copy link
Contributor

@maru-sama maru-sama commented May 4, 2011

Hi everyone,

Once again compilation on 10.5 was broken hey we survived a long time without this. :)
The culprit is da471f1 which teaches Quicksilver how to get recent documents with 10.6 The problem is that 10.5 does not know URLByResolvingBookmarkData so compilation fails. MY first idea was to ifdef this code out as it is, but maybe someone has a better idea to handle that.

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented May 4, 2011

Oh, that was me. :-/
Of course, this can't work on 10.5. And it isn't needed there, because the way recent documents are store was only changed in 10.6. It seems apple suggests for such cases:

if (floor(NSAppKitVersionNumber) <= NSAppKitVersionNumber10_5) {
// 10.5 or less

see SnowLeopard Release Notes.

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented May 4, 2011

oh wait, you were looking for compile time stuff. I guess you're right. Using something like:

#ifdef MAC_OS_X_VERSION_10_6

would be the right thing to do.
Or maybe

#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_6

or it it

MAC_OS_X_VERSION_MAX_ALLOWED

I don't really know :-/

@fheckl fheckl closed this as completed in e29975b May 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants