Quicksilver identifying itself with wrong version (http GET)

[pjrobertson]

Here's a line from the raw access logs of a call my Quicksilver install made to QSApp.com (When I clicked 'check for updates:now':

121.217.xxx.xxx - - [06/Jun/2011:15:34:41 +0100] "GET /versioncheck.php?type=pre&current=3850 HTTP/1.1" 200 24 "-" "Quicksilver/3850 CFNetwork/454.11.12 Darwin/10.7.0 (i386) (MacBook3%2C1)"

As you can see, Quicksilver is saying my version is 10.7.0 - I'm running 10.6.7
Most requests are listed as having a version 10.7.0, but I've seen some 10.8.0 and also 10.7.4

I'm bringing this up now as it may be a problem with requesting plugin list info.

[HenningJ]

QS isn't setting the User-Agent string, so the default is used. Apparently the default is wrong. Seems to be a bug in NSURLRequest?
We could set our own User-Agent, including the correct system version, using something like this: http://stackoverflow.com/questions/1532206/changing-the-useragent-of-nsurlconnection/1533032#1533032

[pjrobertson]

OK, cool.

I think that's already done for other requests, since requests made to
http://qs0.qsapp.com/plugin-data/web-search-list.php
are showing up as "Quicksilver (Blacktree, MacOSX)"
If you google that in the code it's probably just a matter of copy/paste

On 7 June 2011 02:11, HenningJ <
reply@reply.github.com>wrote:

QS isn't setting the User-Agent string, so the default is used. Apparently
the default is wrong. Seems to be a bug in NSURLRequest?
We could set our own User-Agent, including the correct system version,
using something like this:
http://stackoverflow.com/questions/1532206/changing-the-useragent-of-nsurlconnection/1533032#1533032

Reply to this email directly or view it on GitHub:
#355 (comment)

[pjrobertson]

Fixed in pull #374