Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom icons for custom Actions #361

Closed
philostein opened this issue Jun 8, 2011 · 19 comments · Fixed by #548
Closed

Custom icons for custom Actions #361

philostein opened this issue Jun 8, 2011 · 19 comments · Fixed by #548
Assignees

Comments

@philostein
Copy link
Contributor

@philostein philostein commented Jun 8, 2011

I realised that ß60 recognises custom Actions in ~/Library/Application Support/Quicksilver/Actions as QS Actions and gives them the default Action icon.

However…

Would it be possible to restore the ability to display custom icons for scripts in the Actions folder? They're an easy way of differentiating Actions - an option not available for the built-in ones.

It's not just me, there's other(s) out there too. :)

https://twitter.com/rcaldwel/status/78446493723410432

Cheers.

@ghost
Copy link

@ghost ghost commented Jun 9, 2011

how did this use to work? off the top of my head, it'd seem that the best way to do it would be to load the script file's icon, so you could easily set per-action custom icons in the Finder.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 9, 2011

Possibly something to do with the asynchro changes @HenningJ made in 60 and
icon loading.
Not sure though, and just throwing it out there for discussion (I don't use
custom actions)

On 9 June 2011 00:03, philostein <
reply@reply.github.com>wrote:

I realised that 60 recognises custom Actions in ~/Library/Application
Support/Quicksilver/Actions as QS Actions and gives them the default Action
icon.

However

Would it be possible to restore the ability to display custom icons for
scripts in the Actions folder? They're an easy way of differentiating
Actions - an option not available for the built-in ones.

It's not just me, there's other(s) out there too. :)

https://twitter.com/rcaldwel/status/78446493723410432

Cheers.

Reply to this email directly or view it on GitHub:
#361

@philostein
Copy link
Contributor Author

@philostein philostein commented Jun 9, 2011

@neurolepsy
The script's file icon would show which was invariably the default script icon. However, it's easy to change script file icons in Finder and consequently give custom Actions differentiating icons. They look good in QS.

I thought ß60's behaviour was a new feature as I supposed most people don't change the icons, making the default Action icon more useful.

@ybian
Copy link
Contributor

@ybian ybian commented Aug 8, 2011

I have this same problem after installing ß60 (via macport). I have some cute custom action icons for my ruby/AppleScript actions. Not being able to show it makes me unwilling to use them as frequently as before. :(

@ybian
Copy link
Contributor

@ybian ybian commented Aug 8, 2011

I figured it out that it is this commit that causes the problem: f4e8c42

I reverted its fix back (simply move 3 lines around) and my cute icons come back. This is just a quick workaround. Obviously I lose the fix that that commit tried to fix, but I would like to pay that cost.

Someone else may fix this in a proper way.

@clarkewd
Copy link

@clarkewd clarkewd commented Aug 26, 2011

i would like to see this resolved as well :) the different icons can really make a difference in flipping though the custom actions! please bring it back!

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 26, 2011

Great work on tracking down the bad commit @ybian

It was my bad commit, so I'll make it a priority to fix it (unless someone else does so first)
I'll be back into the coding world in around a month, when I'm back from holiday :)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 26, 2011

I can't test, because I'm not at a Mac but just for future reference when I am:

Perhaps reverting the above commit and adding if (![self objectForType:QSURLType]) to line 859 might work.

@skurfer
Copy link
Member

@skurfer skurfer commented Aug 26, 2011

I’ll take a look at it.

@ghost ghost assigned skurfer Aug 26, 2011
@skurfer
Copy link
Member

@skurfer skurfer commented Aug 29, 2011

OK, I did what @pjrobertson suggested and I’m seeing a custom icon for an action now, but I’m not sure what the “bad” commit was meant to fix in the first place, so I’m not sure how to test. I guess my [possibly stupid] question is how I can create a link that has an image defined?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 27, 2011

The 'bad' commit allowed QS to display the actual image instead of the globe when links () were images on web pages.

Right arrowing into google.com atm give a "google's 13th birthday" link with the corresponding image

@clarkewd
Copy link

@clarkewd clarkewd commented Sep 27, 2011

If I'm using a build with this fixed, should I able able to use quicksilver, select a custom action in the first pane, select "set icon" in the second pane, and then select an icns file in the third pane? this changes what icon shows in finder and also when the script is selected in the first pane, but not what icon is shown when the custom action is in the third pane. I may not have a version where this is fixed, but i just wanted to make sure I understood the correct method of how setting a custom icon should work.

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 20, 2011

I see what you mean. The “fix” on my issue361 branch prevents images from loading next to links. I’ll see if I can fix both.

@lgarron
Copy link
Contributor

@lgarron lgarron commented Oct 26, 2011

I don't quite understand this issue, but just confirming: custom actions still do not have custom icons in β61?
E.g. 38579f8 hasn't made it into release?

If I wanted to try this myself, which commit should I check out for beta 61?

@philostein
Copy link
Contributor Author

@philostein philostein commented Oct 26, 2011

Still no custom icons for AppleScript Actions in ~/Library/Application Support/Quicksilver/Actions/ for me in ß61, just the gear icon.

Philip Dooher
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Wednesday, 26 October 2011 at 12:39, Lucas Garron wrote:

I don't quite understand this issue, but just confirming: custom actions still do not have custom icons in β61?
E.g. 38579f8 hasn't made it into release?

If I wanted to try this myself, which commit should I check out for beta 61?

Reply to this email directly or view it on GitHub:
#361 (comment)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 26, 2011

Sorry, you're right. I think the fix for this just got overlooked in the run up to the ß61 release.

I think @skurfer said there were a few problems with 38579f8 hopefully we can merge it in before ß62 though :)

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 26, 2011

I never issued a pull request for the fix because @pjrobertson had some concerns (which turned out to be warranted). So I need to find a way to fix one thing that doesn’t break the other.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 31, 2011

skurfer has issued a pull and this will be fixed in ß62 :)

@philostein
Copy link
Contributor Author

@philostein philostein commented Feb 15, 2014

Thanks very much! (Oh, so late…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants