Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSDuffsRanker (TextMate ranker) anomalies after fix for issue #359 #376

Closed
fheckl opened this issue Jun 11, 2011 · 12 comments
Closed

QSDuffsRanker (TextMate ranker) anomalies after fix for issue #359 #376

fheckl opened this issue Jun 11, 2011 · 12 comments
Assignees
Labels

Comments

@fheckl
Copy link
Contributor

@fheckl fheckl commented Jun 11, 2011

As skurfer mentioned in the discussion for issue #359 my fix had some severe regressions e.g. not switching to text mode when no match present and the preference is enabled.
Will fix them with this issue.

@ghost ghost assigned fheckl Jun 11, 2011
@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 11, 2011

Cool. Looking forward to using a fully functioning Textmate string ranker again. :-)
Maybe you also want to rename it. It was always confusing, since it has nothing to do with Textmate. Maybe something like "Duff String Ranker (former TextMate Ranker)". :-)

@fheckl
Copy link
Contributor Author

@fheckl fheckl commented Jun 11, 2011

I would like to see more opinions on the rename subject. Personally I would agree but I left it out of the pull request for the time being.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 11, 2011

I agree on a rename, but I'm not sure on what's best. Possible discussion for the dev groups?

P.S. Issue #395 doesn't link anywhere...?

@philostein
Copy link
Contributor

@philostein philostein commented Jun 11, 2011

I've bee trying the TextMate ranker in ß60 10.6.7 for a week or so, and I noticed for search it doesn't accept any characters apart from the alphabet. With the Default ranker '#' is handy to search for twitter tags, '<' for HTML code, '*' for a string of special characters I have on the Shelf, and so on.

By the way, I use a kana keyboard that defaults to romajii (roman) text. I've never been able to use '=' for the calculator function either. (Issue #290)

@philostein
Copy link
Contributor

@philostein philostein commented Jun 12, 2011

Names - [something] Ranker:
TextStart
WordStart
Initial

Other acronym style names:
Wranker (contraction of Word Ranker)
Iran (Initials Ranker)
Winker (Word Initials Ranker)

I tried to think of a contraction for 'Word Acronym Ranker', but I couldn't come up with anything, sorry…

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 12, 2011

TextStart Ranker

Seems close enough to TextMate Ranker for people to still know what it is,
and seems more appropriate. I'd be happy with this.

On 12 June 2011 10:05, philostein <
reply@reply.github.com>wrote:

Names - [something] Ranker:
TextStart
WordStart
Initial

Other acronym style names:
Wranker (contraction of Word Ranker)
Iran (Initials Ranker)
Winker (Word Initials Ranker)

I tried to think of a contraction for 'Word Acronym Ranker', but I couldn't
come up with anything, sorry

Reply to this email directly or view it on GitHub:
#376 (comment)

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 12, 2011

I'm fine with any name, as long the Textmate is gone. :-)

@fheckl
Copy link
Contributor Author

@fheckl fheckl commented Jun 12, 2011

Updated issue description. It should reference issue #359.

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 13, 2011

It probably should have been called the Macromates ranker, but I don’t think we can call it that at this point.

I wonder if it’s using the same algorithm that TextMate uses for ⌘T (Go To File), in which case it would be related, but I’ve always thought the name was confusing to people. I’m with @HenningJ. Anything is better than what it is now.

@mckeed
Copy link

@mckeed mckeed commented Jun 24, 2011

Is there an update to the ranker itself? I tried using it with b60 and it's still broken for me. Whenever I try to input anything, I get [DuffStringRanker rankedString]: unrecognized selector...

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 24, 2011

Yes, download it from http://qsapp.com/plugins/ "TextStart Ranker (β60+ only)"

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 30, 2011

All of the issues discussed here have been addressed and included in a new version of the plug-in.

@skurfer skurfer closed this as completed Jun 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants