Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last search is cleared when re-invoking QuickSilver (after long-ish period) #399

Closed
scollard opened this issue Jun 27, 2011 · 18 comments · Fixed by #782
Closed

Last search is cleared when re-invoking QuickSilver (after long-ish period) #399

scollard opened this issue Jun 27, 2011 · 18 comments · Fixed by #782

Comments

@scollard
Copy link

@scollard scollard commented Jun 27, 2011

Starting with B59 and now B60, after some time (10 minutes?) the last search is cleared and a blank magnifying glass appears in the Bezel HUD when invoking QuickSilver. It used to be I could come back days later and my last search would still be there, but now it seems to reset after some period of time. Did something change? I have tried completely re-installing, trashing prefs and caches, etc. ( It's not a huge problem, but it is somewhat annoying. )

To clarify, another user descibed it like this: "if you had something in the first pane, then go do something else, the last thing should still be there the next time you invoke Quicksilver." It works as expected in the short term, but for me appears to clear out somehow after a longer period of time, say 10 minutes (?) of not invoking QS. I thought the 10 minutes was somehow related to the Catalog refresh, so I disabled the Catalog scan and it still forgets the last search.

This is something that changed for me at version B59.

Bizarrely, when I tried removing QS completely and installing the old B54, it did it under B54 on this machine, even though all my other machines running B54 never forget the last search!
-Scott Collard

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 22, 2011

This is indeed true - I stumbled across it today when looking at something else!

For reference: QSinterfaceController.m:436

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

My Lion 10.7.2 running QS b61 clears action state immediately. The search box still has the last item preselected though.
Should I create a seperate issue for this? It might not be related.

Btw, I was running b60 before this and had no such issues.

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 25, 2011

The list of actions is recalculated all the time. When I bring up QS, I see that the second pane is blank, but it fills in almost immediately. Are you saying it stays blank?

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

No, it fills it up asap with the top ranked action…but the point is it should be stateful and reflect the last user input….like it always was. If this has been deliberately changed, I think you should have consulted the user base, for I am quite sure people are fond of QS keeping state of their input.


On 25Oct, 2011, at 03:52 , Rob McBroom wrote:

The list of actions is recalculated all the time. When I bring up QS, I see that the second pane is blank, but it fills in almost immediately. Are you saying it stays blank?

Reply to this email directly or view it on GitHub:
#399 (comment)

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

I just reinstalled b60 to see if I could get this to work again, but that didn't work :(

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

Plus, it seems to not save preference anymore for my most used actions. Should I file a seperate issue for that?

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

I am a bit sad now. I am giving a mac osx power course tomorrow for 20 people, and QS is the main part of the course. But my QS has all these state issues which I can't seem to get around by downgrading. Did something change to the ranking storage that makes downgrading fail?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 25, 2011

The ranking details have not been changed at all between 60 and 61.
Make sure you quit Quicksilver gracefully after changing the ranking score
in the Actions Preferences (don't force quit, otherwise they won't be saved)
Dragging the actions up/down should definitely work to change the action
order. Make sure you're in the 'All Actions' view and you are definitely
dragging your desired action above the already default action.

Resetting the action pane has been the behaviour for as long as I can
remember.

I will be around for troubleshooting today, so if you need to get this
sorted before your course then I am here!

Thanks

On 25 October 2011 03:09, Maurice Faber <
reply@reply.github.com>wrote:

I am a bit sad now. I am giving a mac osx power course tomorrow for 20
people, and QS is the main part of the course. But my QS has all these state
issues which I can't seem to get around by downgrading. Did something change
to the ranking storage that makes downgrading fail?

Reply to this email directly or view it on GitHub:
#399 (comment)

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

Wow, you're so sweet!

But maybe I have another problem then. Because my QS used to keep state, and now it doesn't.

I also noticed my QS is not dynamically learning my preferences anymore.Even when I have done 'Firefox > Open' many times, it still keeps offering 'Firefox > Email to (Compose)' because that has a higher ranking.

So there's two major issues:

  • QS is not keeping state of the last user input, and instead tries to do a fresh suggest. (see the action box suddenly fill up with the highest ranking action)
  • QS is not learning preferred actions anymore. (maybe the above 'sudden' fill up is the culprit here)

Seems to me somebody committed the wrong lines here. Are you reviewing each others code sufficiently?
My apologies for not fixing it myself, but I am not an Objective C programmer, or C for that matter, and don't wish to become one soon.

Tnx for keeping QS alive!

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 25, 2011

We are indeed all reviewing each other's code :)
Quicksilver is such a big (and complicated) project that it's not always
clear what changing some things will do in other areas.

If you open up the drop-down window for the actions, find the action you
want (e.g. Open for firefox) and then select the little circle next to it
and click 'make default'. Does that work?
do you want 'email to (Compose)' to be higher than open? i.e. you are
performing it more often than 'open'? If not, then change it in the 'files &
folders' prefs in the actions preferences.

On 25 October 2011 09:38, Maurice Faber <
reply@reply.github.com>wrote:

Wow, you're so sweet!

But maybe I have another problem then. Because my QS used to keep state,
and now it doesn't.

I also noticed my QS is not dynamically learning my preferences
anymore.Even when I have done 'Firefox > Open' many times, it still keeps
offering 'Firefox > Email to (Compose)' because that has a higher ranking.

So there's two major issues:

  • QS is not keeping state of the last user input, and instead tries to do a
    fresh suggest. (see the action box suddenly fill up with the highest ranking
    action)
  • QS is not learning preferred actions anymore. (maybe the above 'sudden'
    fill up is the culprit here)

Seems to me somebody committed the wrong lines here. Are you reviewing each
others code sufficiently?
My apologies for not fixing it myself, but I am not an Objective C
programmer, or C for that matter, and don't wish to become one soon.

Tnx for keeping QS alive!

Reply to this email directly or view it on GitHub:
#399 (comment)

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

I understand the ranking mechanism. But QS is definitely not doing anything with the 'score' assigned to the actions.

use case: choose Firefox, and TAB, "Email to (Compose)" pops up.

If I click the bullet next to the always prevailing 'Email to (Compose)' (which I set to rank 3), it does not even have a 'score'. Shouldn't the actions have a score assigned, even without typing one letter?

Btw, is your setup working ok?


On 25Oct, 2011, at 10:42 , Patrick Robertson wrote:

We are indeed all reviewing each other's code :)
Quicksilver is such a big (and complicated) project that it's not always
clear what changing some things will do in other areas.

If you open up the drop-down window for the actions, find the action you
want (e.g. Open for firefox) and then select the little circle next to it
and click 'make default'. Does that work?
do you want 'email to (Compose)' to be higher than open? i.e. you are
performing it more often than 'open'? If not, then change it in the 'files &
folders' prefs in the actions preferences.

On 25 October 2011 09:38, Maurice Faber <
reply@reply.github.com>wrote:

Wow, you're so sweet!

But maybe I have another problem then. Because my QS used to keep state,
and now it doesn't.

I also noticed my QS is not dynamically learning my preferences
anymore.Even when I have done 'Firefox > Open' many times, it still keeps
offering 'Firefox > Email to (Compose)' because that has a higher ranking.

So there's two major issues:

  • QS is not keeping state of the last user input, and instead tries to do a
    fresh suggest. (see the action box suddenly fill up with the highest ranking
    action)
  • QS is not learning preferred actions anymore. (maybe the above 'sudden'
    fill up is the culprit here)

Seems to me somebody committed the wrong lines here. Are you reviewing each
others code sufficiently?
My apologies for not fixing it myself, but I am not an Objective C
programmer, or C for that matter, and don't wish to become one soon.

Tnx for keeping QS alive!

Reply to this email directly or view it on GitHub:
#399 (comment)

Reply to this email directly or view it on GitHub:
#399 (comment)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 25, 2011

The actions have never had a score, only a rank for as long as I can
remember!

I have just tried 54 (the last version before Quicksilver went open source)
and there was not 'score' setting for actions if no letter is typed Only
'Rank' as seen in this picture:

http://i.imgur.com/owXks.png

The 'score' that is assigned when no letters are pressed are the 'rank' that
you see in the actions preferences.

I'm 99% sure that this is the way it has always been, but I guess you're
saying something changed for you ;(

On 25 October 2011 09:51, Maurice Faber <
reply@reply.github.com>wrote:

I understand the ranking mechanism. But QS is definitely not doing anything
with the 'score' assigned to the actions.

use case: choose Firefox, and TAB, "Email to (Compose)" pops up.

If I click the bullet next to the always prevailing 'Email to (Compose)'
(which I set to rank 3), it does not even have a 'score'. Shouldn't the
actions have a score assigned, even without typing one letter?

Btw, is your setup working ok?


On 25Oct, 2011, at 10:42 , Patrick Robertson wrote:

We are indeed all reviewing each other's code :)
Quicksilver is such a big (and complicated) project that it's not always
clear what changing some things will do in other areas.

If you open up the drop-down window for the actions, find the action you
want (e.g. Open for firefox) and then select the little circle next to it
and click 'make default'. Does that work?
do you want 'email to (Compose)' to be higher than open? i.e. you are
performing it more often than 'open'? If not, then change it in the
'files &
folders' prefs in the actions preferences.

On 25 October 2011 09:38, Maurice Faber <
reply@reply.github.com>wrote:

Wow, you're so sweet!

But maybe I have another problem then. Because my QS used to keep state,
and now it doesn't.

I also noticed my QS is not dynamically learning my preferences
anymore.Even when I have done 'Firefox > Open' many times, it still
keeps
offering 'Firefox > Email to (Compose)' because that has a higher
ranking.

So there's two major issues:

  • QS is not keeping state of the last user input, and instead tries to
    do a
    fresh suggest. (see the action box suddenly fill up with the highest
    ranking
    action)
  • QS is not learning preferred actions anymore. (maybe the above
    'sudden'
    fill up is the culprit here)

Seems to me somebody committed the wrong lines here. Are you reviewing
each
others code sufficiently?
My apologies for not fixing it myself, but I am not an Objective C
programmer, or C for that matter, and don't wish to become one soon.

Tnx for keeping QS alive!

Reply to this email directly or view it on GitHub:

#399 (comment)

Reply to this email directly or view it on GitHub:

#399 (comment)

Reply to this email directly or view it on GitHub:
#399 (comment)

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

Don't you see the 'score' for an action? I do.

And I am pretty sure my action preferences were kept. And I can imagine this 'score' to be at the base of that.
Maybe you are not aware of all the features?

Do you guys have a direct connection with the inventor? He would surely know….

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 25, 2011

As I've said, the 'score' only shows up after you have typed at least one
letter:

http://i.imgur.com/VZVLS.png

The 'score' for when no letters are typed reverts to the rank. If you are
100% sure that things have changed for you, then I suggest reverting to an
earlier file version for ~/Library/Application
Support/Quicksilver/Actions.plist and using 60.

Again, knowing the code - this is how Quicksilver was designed ;)

On 25 October 2011 10:17, Maurice Faber <
reply@reply.github.com>wrote:

Don't you see the 'score' for an action? I do.

And I am pretty sure my action preferences were kept. And I can imagine
this 'score' to be at the base of that.
Maybe you are not aware of all the features?

Do you guys have a direct connection with the inventor? He would surely
know.

Reply to this email directly or view it on GitHub:
#399 (comment)

@Morriz
Copy link

@Morriz Morriz commented Oct 25, 2011

Thanks for helping out Patrick, I have found that setting an action to the default is helping. It even remembers state that way. Strange that you have to do this manually tho, as the old QS would just 'remember'.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 25, 2011

Great, glad to know you've got things working again :) Good luck with your
course!

On 25 October 2011 10:22, Maurice Faber <
reply@reply.github.com>wrote:

Thanks for helping out Patrick, I have found that setting an action to the
default is helping. It even remembers state that way. Strange that you have
to do this manually tho, as the old QS would just 'remember'.

Reply to this email directly or view it on GitHub:
#399 (comment)

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 25, 2011

As far as I know, B54 will still run on Lion. (You just won’t be able to edit preferences and you might have to disable some of the newer plug-ins.) Maybe you should run it for a while and see if the behavior you describe is the same as 61.

I’ve been using QS for a long time, and while automatically ranking actions seems like something it would do and if you asked me, I’d probably say “sure, it does that”, I can’t actually think of a concrete example of it happening.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 2, 2012

This will be fixed in the next release of Quicksilver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants