Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more than one plugin to add actions for the same application #460

Closed
charles-e opened this issue Aug 16, 2011 · 1 comment · Fixed by #2605
Closed

Allow more than one plugin to add actions for the same application #460

charles-e opened this issue Aug 16, 2011 · 1 comment · Fixed by #2605

Comments

@charles-e
Copy link

Right now when adding the application actions from a plugin's
QSRegistry dictionary QS simply calls addEntriesFromDictionary. What
this means is that for a given application with a given bundle identifier
only one plugin can add application actions. And if two different
plugins attempt to add application actions for a given app, which ever
plugin is loaded/registered last "wins".
I discovered this because I tried to write a little QSPlugin to add an
update podcast application action for iTunes to sit along side the
Previous/Next Track actions.
@ghost ghost self-assigned this Aug 16, 2011
@pjrobertson pjrobertson mentioned this issue Feb 12, 2022
Merged
pjrobertson added a commit that referenced this issue Feb 12, 2022
@pjrobertson
Don't overwrite existing QSApplicationActions entries in QSReg when l…
72d1dc5 
…oading plugins

Previously, the last plugin to create QSApplicationActions for a certain app's action would overwrite any existing actions.
This change adds the any new actions to the existing ones, instead of blindly over-writing

Fixes #460
skurfer pushed a commit that referenced this issue Feb 13, 2022
@pjrobertson
Don't overwrite existing QSApplicationActions entries in QSReg when l…
46509ef 
…oading plugins (#2605)

Previously, the last plugin to create QSApplicationActions for a certain app's action would overwrite any existing actions.
This change adds the any new actions to the existing ones, instead of blindly over-writing

Fixes #460
@pjrobertson
Copy link
Member

It's been a while, @charles-e - but this has now been fixed ;-)

Feel free to create plugins at ease 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #460 quicksilver/Quicksilver
2 participants
@pjrobertson @charles-e