Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third pane not showing for (example.scpt)(Open File...) #603

Closed
Sesquipedalian opened this issue Dec 4, 2011 · 17 comments
Closed

Third pane not showing for (example.scpt)(Open File...) #603

Sesquipedalian opened this issue Dec 4, 2011 · 17 comments
Assignees
Milestone

Comments

@Sesquipedalian
Copy link

@Sesquipedalian Sesquipedalian commented Dec 4, 2011

AppleScripts that include the on open handler are given the Open File... action in QS. However, the third pane is not made available to select a file.

To reproduce:

  1. Create and save an AppleScript with the following contents:

on open theFile
tell application "Finder" to display dialog name of theFile
end open

  1. Select the AppleScript in QS.
  2. Select the Open File... action in QS
  3. Try in vain to tab into the third pane, only to find yourself cycling between the first and second panes instead.

Quicksilver β63(3912)
Mac OS X 10.7.2

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 4, 2011

I'm not too sure myself how that action works. Perhaps you want to save the applescript in the Actions folder in ~/Library/Application Support/Quicksilver/Actions and then run it as an action?

@philostein knows a lot more about applescripts than me.

@skurfer
Copy link
Member

@skurfer skurfer commented Dec 5, 2011

Sounds similar to the problem we had with “process text”. It’s been a while since I looked at that section of the code, but I’d bet it has to do with the argument count being determined incorrectly.

@Sesquipedalian
Copy link
Author

@Sesquipedalian Sesquipedalian commented Dec 11, 2011

So, is this going to be assigned to anyone? Running AppleScripts in this way is one of my favourite ways to use QS. :)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 11, 2011

Unfortunately a lot of us have our hands full at the moment.

Can you pinpoint when this bug was introduced? Which QS version? That will make it easier for us to track and fix.

@skurfer
Copy link
Member

@skurfer skurfer commented Dec 12, 2011

So, is this going to be assigned to anyone?

The majority of issues never get assigned. Don’t read too much into it. :-)

@Sesquipedalian
Copy link
Author

@Sesquipedalian Sesquipedalian commented Dec 14, 2011

The bug is present in β62. For whatever reason, when I try to test using β61 and lower, the Open File... action is not available at all (probably a side effect of running an older version with a set of prefs from β63), so I can't say for sure if it was present then.

Jon

On 2011-12-11, at 3:46 PM, Patrick Robertson wrote:

Unfortunately a lot of us have our hands full at the moment.

Can you pinpoint when this bug was introduced? Which QS version? That will make it easier for us to track and fix.


Reply to this email directly or view it on GitHub:
#603 (comment)

@ghost ghost assigned skurfer Jan 25, 2012
@skurfer
Copy link
Member

@skurfer skurfer commented Jan 25, 2012

When I work on #623, I’ll probably be in the neighborhood of where this happens, so I’ll try to look at it too.

probably a side effect of running an older version with a set of prefs from β63

I still run B54 sometimes and it works just fine. :-) There were other similar problems with AppleScript and process text at the time. Maybe that’s why the action doesn’t show up.

@Sesquipedalian
Copy link
Author

@Sesquipedalian Sesquipedalian commented Jan 25, 2012

Excellent!

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 25, 2012

I'm not sure how busy @ddlsmurf is at the moment, but he worked on allowing
AppleScripts to use the 3rd pane not so long ago. He may be able to give a
few pointers, even if he doesn't have enough time to help out directly.

On 25 January 2012 19:00, Sesquipedalian <
reply@reply.github.com

wrote:

Excellent!


Reply to this email directly or view it on GitHub:
#603 (comment)

@ddlsmurf
Copy link
Contributor

@ddlsmurf ddlsmurf commented Jan 26, 2012

Sorry, IIRC, my work was on when the apple script is an action, I have no insight on this one...

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 26, 2012

Sorry Eric, I guess I must have mixed things up. I appreciate you getting back to us!

Good luck with everything

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 26, 2012

Yeah, what @ddlsmurf did involved fancy new features. I suspect this is just a bug somewhere involving argumentCount.

@ddlsmurf
Copy link
Contributor

@ddlsmurf ddlsmurf commented Jan 26, 2012

From a a very brief github browse, it looks like this should also handle kAppleScriptOpenFilesAction. (sorry can't compile here and try)

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 26, 2012

From a a very brief github browse, it looks like this should also handle kAppleScriptOpenFilesAction. (sorry can't compile here and try)

That was it.

@lovequicksilver
Copy link

@lovequicksilver lovequicksilver commented Feb 19, 2012

Thanks, I can confirm this is working in ß65 Lion.

In Lion, if you're testing, the Finder line needs to read:

tell application "Finder" to display dialog (name of item 1 of theFile)

@Sesquipedalian
Copy link
Author

@Sesquipedalian Sesquipedalian commented Feb 19, 2012

EDIT: Never mind, I misread lovequicksilver's post.

Thanks to skurfer for fixing this!

@lovequicksilver
Copy link

@lovequicksilver lovequicksilver commented Feb 19, 2012

Apologies, should've been more specific.

The script produces pane 3 and executes, but doesn't show any visible result. I seem to recall that before SL, a single file selection's class was an alias(?) as opposed to a list for multiple items. In Lion at least, a single file selection is also returned as a list. Finder can't display a list in a dialog.

My new code still fails though, so here's a revised version:

set _name to (name of item 1 of theFile)
display dialog _name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants