Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drilling down redirects to root #63

Closed
jpcody opened this issue Feb 20, 2010 · 8 comments
Closed

Drilling down redirects to root #63

jpcody opened this issue Feb 20, 2010 · 8 comments
Assignees
Labels

Comments

@jpcody
Copy link

@jpcody jpcody commented Feb 20, 2010

Occasionally, in certain folder, as I try to drill down with a forward slash, I get taken back to my hard drive root. Generally, Quicksilver will get into a rhythm of kicking me back after certain strings. For example: "App / MAM / ht /" might kick me back to home, while "App / MAM / htd /" will not. A logout or restart fixes this issue, but it persists until then. No idea what causes the bug to begin.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 20, 2010

Are you sure this isn't because you're holding "/" for too long? Holding "/" takes you to the root in QS.

Have you tried using the right arrow? It does the same as "/" but does it also have this problem?

@jpcody
Copy link
Author

@jpcody jpcody commented Feb 21, 2010

I wish this were the case. It's an extremely quick (nearly instantaneous) keystroke that's causing the issue. Interestingly, if I access a folder until the issue begins, then I switch to the right arrow for a drill down instead of the forward slash, the issue seems to be fixed momentarily. After right-arrow-ing once, I get a few more times before the forward slash stops working again.

@iaj
Copy link

@iaj iaj commented Apr 25, 2011

Same for me, but this happens only, when - as jpcody pointed out - trying to drill down fast.. eg. hit the / immediately after typing the last letter of the folder I'm trying to navigating too. Right arrow never gave me that behaviour... Is there any way to disable the / thing? Can be quite annoying sometimes when I drilled down to a folder very deep in my filesystem :-)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 25, 2011

I can now reproduce this.

For me, if you hit any character then the '/' character immediately after you get this problem.

E.g.:
type ~
type '/'
type 'l' (for Library folder) then '/' immediately

Looks like the dual use of '/' as a 'go to root' and drill down is somehow being mistaken here when it's used straight after another keypress. Maybe reduce the 'delay' QS sees between the two?

Also, holding '/' too long redirects you to your Applications folder (I.e. it registers the '/' press as a 'go to root and drill down one level')

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 26, 2011

This is caused by the

handleSlashEvent: method in QSSearchObjectView.m:1068 looking for when the '/' key was released. It checks after 0.25s to see if the key was released. If you somehow (e.g. by rapid drilling) press the '/' key, release it, then 0.25s later you release the '/' again (say after drilling down into another folder) QS will not realise it's NOT the same key press, and will hence redirect you to root.

There should be some kind of if statement such as

if(no other key was pressed in the meantime)
or
if(last key down was the '/' key)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 26, 2011

Here's what 'theEvent' gives, maybe do something with the 'time'?

 2011-04-26 13:03:27.928 Quicksilver[31298:a0f] theEvent: NSEvent: type=KeyDown loc=(0,218) time=651667.1 flags=0x100 win=0x0 winNum=68629 ctxt=0x2022b chars="/" unmodchars="/" repeat=0 keyCode=44

@ghost ghost assigned pjrobertson Apr 26, 2011
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 26, 2011

OK I've got a fix. I just want to comment some more then I'll issue a pull request

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 4, 2011

Fixes in the latest HEAD.

Will be in ß60 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants