Catalog sources requiring web connection cleared if offline

[pjrobertson]

I can only think of the Web Search module where this applies.

Steps to reproduce:

• Disable your internet connection
• Go into Prefs > Catalog > Modules
• Click the refresh icon for whichever web searches catalog source you have enabled
• The source is cleared

What should really happen: QS should detect you have no internet and leave things as is.

[skurfer]

My opinion: The object source should be responsible for figuring this out. The most logical solution is probably to test for a connection in indexIsValidFromDate:forEntry: and return YES if it’s not available.

[pjrobertson]

Goot idea, I hadn't thought of that. It'd be pretty simple really, since
it's just the QSWebSource stuff.

I've made this v1.0 milestone. I was feeling a bit left you ;)

On 4 May 2012 13:54, Rob McBroom <
reply@reply.github.com

wrote:

My opinion: The object source should be responsible for figuring this out.
The most logical solution is probably to test for a connection in
indexIsValidFromDate:forEntry: and return YES if it’s not available.

---

Reply to this email directly or view it on GitHub:
#634 (comment)

[skurfer]

Yeah, that could always be bypassed by a manual rescan, but if you force a scan of a web source with no Internet connection, you get what you deserve. :-)