Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog sources requiring web connection cleared if offline #634

Closed
pjrobertson opened this issue Jan 14, 2012 · 3 comments
Closed

Catalog sources requiring web connection cleared if offline #634

pjrobertson opened this issue Jan 14, 2012 · 3 comments
Milestone

Comments

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 14, 2012

I can only think of the Web Search module where this applies.

Steps to reproduce:

  • Disable your internet connection
  • Go into Prefs > Catalog > Modules
  • Click the refresh icon for whichever web searches catalog source you have enabled
  • The source is cleared

What should really happen: QS should detect you have no internet and leave things as is.

@skurfer
Copy link
Member

@skurfer skurfer commented May 4, 2012

My opinion: The object source should be responsible for figuring this out. The most logical solution is probably to test for a connection in indexIsValidFromDate:forEntry: and return YES if it’s not available.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented May 4, 2012

Goot idea, I hadn't thought of that. It'd be pretty simple really, since
it's just the QSWebSource stuff.

I've made this v1.0 milestone. I was feeling a bit left you ;)

On 4 May 2012 13:54, Rob McBroom <
reply@reply.github.com

wrote:

My opinion: The object source should be responsible for figuring this out.
The most logical solution is probably to test for a connection in
indexIsValidFromDate:forEntry: and return YES if it’s not available.


Reply to this email directly or view it on GitHub:
#634 (comment)

@skurfer
Copy link
Member

@skurfer skurfer commented May 4, 2012

Yeah, that could always be bypassed by a manual rescan, but if you force a scan of a web source with no Internet connection, you get what you deserve. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants